Re: [PATCH v8 10/13] libxl/xl: deprecate the build_info->cpumap field

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1532 bytes --]

On ven, 2014-06-13 at 14:49 +0100, Wei Liu wrote:
> On Fri, Jun 13, 2014 at 02:34:48PM +0100, Wei Liu wrote:
> [...]
> > >      }
> > >      libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap);
> > > -    libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus,
> > > -                               &info->cpumap, NULL);
> > >  
> > 
> > So you actually remove cpumap handling logic in libxl as well? IMHO this
> > is not right.
> > 
> > Consider older application can set this map and now with the new library
> > CPU is not pinned anymore. I think you can effectively transform cpumap
> > to vcpu_hard_affinity list in libxl level to avoid functional regression
> > if cpumap is set and vcpu_hard_affinity is not set by application. If
> > both cpumap and vcpu_hard_affinity are set, vcpu_hard_affinity takes
> > precedence.
> > 
> 
> Acutally you don't need to transform it at all -- just don't remove
> the call to libxl_set_vcpuaffinity_all. :-)
> 
So, not meaning to push, just checking: is this the only comment on the
series? Can/should I respin it with that changed? Or are people still
looking at the patches?

(Of course, I'd be reposing the toolstack side only of the series, as
Jan already pushed the hv part).

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel