From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, Andrew.Cooper3@citrix.com,
George.Dunlap@citrix.com, xen-devel@lists.xen.org,
JBeulich@suse.com, Ian.Jackson@citrix.com,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v8 10/13] libxl/xl: deprecate the build_info->cpumap field
Date: Tue, 17 Jun 2014 12:11:29 +0200 [thread overview]
Message-ID: <1402999889.16864.20.camel@Solace> (raw)
In-Reply-To: <1402666712.19520.14.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1103 bytes --]
On ven, 2014-06-13 at 14:38 +0100, Ian Campbell wrote:
> On Fri, 2014-06-13 at 14:34 +0100, Wei Liu wrote:
> > > @@ -261,8 +261,6 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
> > > return rc;
> > > }
> > > libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap);
> > > - libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus,
> > > - &info->cpumap, NULL);
> > >
> >
> > So you actually remove cpumap handling logic in libxl as well? IMHO this
> > is not right.
>
> Correct.
>
> Old apps which are using the deprecated field must continue to work,
> which means handling the deprecated field internally.
>
Right. Fixing it for v9 (which I'm waiting a bit more to post, to try
gathering some more comments, if any).
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-06-17 10:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 13:09 [PATCH v8 00/13] Implement vcpu soft affinity for credit1 Dario Faggioli
2014-06-13 13:09 ` [PATCH v8 01/13] xen: sched: rename v->cpu_affinity into v->cpu_hard_affinity Dario Faggioli
2014-06-13 13:09 ` [PATCH v8 02/13] xen: sched: introduce soft-affinity and use it instead d->node-affinity Dario Faggioli
2014-06-13 13:09 ` [PATCH v8 03/13] xen: derive NUMA node affinity from hard and soft CPU affinity Dario Faggioli
2014-06-13 13:09 ` [PATCH v8 04/13] xen/libxc: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity Dario Faggioli
2014-06-13 13:09 ` [PATCH v8 05/13] libxc/libxl: bump library SONAMEs Dario Faggioli
2014-06-13 13:09 ` [PATCH v8 06/13] libxc: get and set soft and hard affinity Dario Faggioli
2014-06-13 13:10 ` [PATCH v8 07/13] libxl: get and set soft affinity Dario Faggioli
2014-06-13 13:10 ` [PATCH v8 08/13] xl: enable getting and setting " Dario Faggioli
2014-06-13 13:10 ` [PATCH v8 09/13] libxl/xl: push VCPU affinity pinning down to libxl Dario Faggioli
2014-06-13 13:25 ` Wei Liu
2014-06-17 10:09 ` Dario Faggioli
2014-06-13 13:10 ` [PATCH v8 10/13] libxl/xl: deprecate the build_info->cpumap field Dario Faggioli
2014-06-13 13:34 ` Wei Liu
2014-06-13 13:38 ` Ian Campbell
2014-06-17 10:11 ` Dario Faggioli [this message]
2014-06-13 13:49 ` Wei Liu
2014-06-17 9:59 ` Dario Faggioli
2014-06-17 10:16 ` Wei Liu
2014-06-17 10:29 ` Dario Faggioli
2014-06-17 10:45 ` Wei Liu
2014-06-13 13:10 ` [PATCH v8 11/13] xl: move the vcpu affinity parsing in a function Dario Faggioli
2014-06-13 13:10 ` [PATCH v8 12/13] xl: enable for specifying soft-affinity in the config file Dario Faggioli
2014-06-17 10:34 ` Wei Liu
2014-06-13 13:10 ` [PATCH v8 13/13] libxl: automatic NUMA placement affects soft affinity Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402999889.16864.20.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.