Re: [RFC PATCH 2/4] Add cbs parameter support to xl tool stack, remove defunct sedf parameters

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2538 bytes --]

The core of this patch, as well as of patches 3 and 4, is renaming
*_sedf to *_cbs, on which I think I commented already... let's see where
that discussion goes.

So, leaving the renaming part aside...

On ven, 2014-06-13 at 15:58 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@dornerworks.com>
> 
> ---
>  docs/man/xl.cfg.pod.5             |    9 ++----
>  tools/libxc/xc_sedf.c             |   16 +++-------
>  tools/libxc/xenctrl.h             |   12 +++----
>  tools/libxl/libxl.c               |   31 ++++++-------------
>  tools/libxl/libxl.h               |    3 +-
>  tools/libxl/libxl_create.c        |   61 ------------------------------------
>  tools/libxl/libxl_types.idl       |    3 +-
>  tools/libxl/xl_cmdimpl.c          |   62 ++++++++++---------------------------
>  tools/libxl/xl_cmdtable.c         |    8 ++---
>  tools/python/xen/lowlevel/xc/xc.c |   34 +++++++++-----------
>  xen/include/public/domctl.h       |    4 +--
>
What we usually do is splitting the series so that you cross the various
components' boundaries as few as possible.

That means, for instance, in this case, having one (or more) patch(es)
modifying libxc, one or more modifying libxl and, if possible, one or
more modifying xl.

That is, mostly, for making the review easier, but also because it may
be that different components are under the umbrella of different
maintainer and/or committers.

When modifying libxl, please mind the issue of API stability that I
brought up in this thread already.

>  11 files changed, 58 insertions(+), 185 deletions(-)
>  mode change 100644 => 100755 docs/man/xl.cfg.pod.5
>  mode change 100644 => 100755 tools/libxc/xc_sedf.c
>  mode change 100644 => 100755 tools/libxc/xenctrl.h
>  mode change 100644 => 100755 tools/libxl/libxl.c
>  mode change 100644 => 100755 tools/libxl/libxl.h
>  mode change 100644 => 100755 tools/libxl/libxl_types.idl
>  mode change 100644 => 100755 tools/libxl/xl_cmdimpl.c
>  mode change 100644 => 100755 tools/libxl/xl_cmdtable.c
>  mode change 100644 => 100755 tools/python/xen/lowlevel/xc/xc.c
>  mode change 100644 => 100755 xen/include/public/domctl.h
> 
What are these? I really don't think they should be here.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel