Re: [PATCH v10 07/11] libxl/xl: deprecate the build_info->cpumap field

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1628 bytes --]

On ven, 2014-06-27 at 11:57 +0100, Ian Campbell wrote:

> > --- a/tools/libxl/libxl_types.idl
> > +++ b/tools/libxl/libxl_types.idl
> > @@ -301,7 +301,13 @@ libxl_domain_sched_params = Struct("domain_sched_params",[
> >  libxl_domain_build_info = Struct("domain_build_info",[
> >      ("max_vcpus",       integer),
> >      ("avail_vcpus",     libxl_bitmap),
> > -    ("cpumap",          libxl_bitmap),
> > +    ("cpumap",          libxl_bitmap), # DEPRECATED!
> > +    # The cpumap field above has been deprecated by the introduction of the
> > +    # vcpu_hard_affinity array. It is not removed and it is still honoured, for
> > +    # API stability and backward compatibility reasons, but should not be used
> > +    # any longer. The vcpu_hard_affinity array is what should be used instead.
> > +    # As per libxl.h, if both cpumap and vcpu_hard_affinity are used, the latter
> > +    # will prevail.
> 
> Likewise I think here. Perhaps "DEPRECATED: Use vcpu_hard_affinity"
> would be OK. But I'm more inclined to suggest we just drop this entire
> patch. After all we can effectively never get rid of this field and
> people are entitled to keep using it.
> 
Understood. Andagreed. I'll get rid of this patch for v11, and change
the commit messages of the other patches in the series that refers to
this deprecation.

Thanks,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel