From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Andrew.Cooper3@citrix.com, xen-devel@lists.xen.org,
Wei Liu <wei.liu2@citrix.com>,
Ian.Jackson@citrix.com
Subject: Re: [PATCH v10 08/11] xl: move away from the (deprecated) use of cpumap for hard affinity
Date: Fri, 27 Jun 2014 14:24:48 +0200 [thread overview]
Message-ID: <1403871888.8515.12.camel@Solace> (raw)
In-Reply-To: <1403866808.25894.25.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1217 bytes --]
On ven, 2014-06-27 at 12:00 +0100, Ian Campbell wrote:
> On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> > + const char *buf2 = NULL; //XXX Trick the compiler!!!
>
> This comment needs to be removed one way or another...
>
Wow, sorry. I could have sworn I removed it before posting! :-(
> I'm unsure about the "= NULL" since I'm not sure what it is trying to
> achieve.
>
Ok, Now I've seen what happened. I removed the comment from the wrong
patch, and then did not realize the fact that it made it into the series
in two other patches. Will fix this.
Anyway, the explanation of why I think I need the =NULL is in patch 10,
when the comment is actually replaced with something more sensible.
It would be wonderful if you could at least have a look at that hunk,
and tell me whether you think the reasoning behind suppressing the
warning is sound, and the explanation clear enough.
Thanks in advance,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-06-27 12:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 16:18 [PATCH v10 00/11] Series short description Dario Faggioli
2014-06-20 16:18 ` [PATCH v10 01/11] libxc/libxl: bump library SONAMEs Dario Faggioli
2014-06-20 16:19 ` [PATCH v10 02/11] libxc: get and set soft and hard affinity Dario Faggioli
2014-06-20 16:19 ` [PATCH v10 03/11] libxl: get and set soft affinity Dario Faggioli
2014-06-20 16:19 ` [PATCH v10 04/11] xl: enable getting and setting " Dario Faggioli
2014-06-27 12:33 ` Ian Campbell
2014-06-27 13:18 ` Dario Faggioli
2014-06-27 13:22 ` Ian Campbell
2014-06-27 13:45 ` Dario Faggioli
2014-06-20 16:19 ` [PATCH v10 05/11] libxl: Change default for b_info->{cpu, node}map to "not allocated" Dario Faggioli
2014-06-27 10:44 ` Ian Campbell
2014-06-27 12:07 ` Dario Faggioli
2014-06-27 12:44 ` Ian Campbell
2014-06-20 16:19 ` [PATCH v10 06/11] libxl/xl: push VCPU affinity pinning down to libxl Dario Faggioli
2014-06-27 10:55 ` Ian Campbell
2014-06-20 16:19 ` [PATCH v10 07/11] libxl/xl: deprecate the build_info->cpumap field Dario Faggioli
2014-06-27 10:57 ` Ian Campbell
2014-06-27 12:08 ` Dario Faggioli
2014-06-20 16:19 ` [PATCH v10 08/11] xl: move away from the (deprecated) use of cpumap for hard affinity Dario Faggioli
2014-06-27 11:00 ` Ian Campbell
2014-06-27 12:24 ` Dario Faggioli [this message]
2014-06-20 16:20 ` [PATCH v10 09/11] xl: move the vcpu affinity parsing in a function Dario Faggioli
2014-06-20 16:20 ` [PATCH v10 10/11] libxl/xl: make it possible to specify soft-affinity in domain config file Dario Faggioli
2014-06-27 12:47 ` Ian Campbell
2014-06-27 13:07 ` Dario Faggioli
2014-06-27 16:41 ` Dario Faggioli
2014-06-20 16:20 ` [PATCH v10 11/11] libxl: automatic NUMA placement affects soft affinity Dario Faggioli
2014-06-27 13:32 ` [PATCH v10 00/11] Series short description Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403871888.8515.12.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.