From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: jroedel-l3A5Bk7waGM@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: [RFC PATCH v2 5/7] dma-mapping: detect and configure IOMMU in of_dma_configure
Date: Tue, 2 Sep 2014 18:56:25 +0100 [thread overview]
Message-ID: <1409680587-29818-6-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1409680587-29818-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
This patch extends of_dma_configure so that it sets up the IOMMU for a
device, as well as the coherent/non-coherent DMA mapping ops.
Signed-off-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
---
arch/arm/include/asm/dma-mapping.h | 5 ++++-
drivers/of/platform.c | 36 ++++++++++++++++++++++--------------
include/linux/dma-mapping.h | 5 ++++-
3 files changed, 30 insertions(+), 16 deletions(-)
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
index dad006dabbe6..788b8eef40e8 100644
--- a/arch/arm/include/asm/dma-mapping.h
+++ b/arch/arm/include/asm/dma-mapping.h
@@ -122,7 +122,10 @@ static inline unsigned long dma_max_pfn(struct device *dev)
#define dma_max_pfn(dev) dma_max_pfn(dev)
static inline void arch_setup_dma_ops(struct device *dev, u64 mask,
- unsigned long offset, bool coherent)
+ u64 dma_base, u64 size,
+ unsigned long offset,
+ struct iommu_dma_mapping *iommu,
+ bool coherent)
{
dev->coherent_dma_mask = mask;
dev->dma_mask = &dev->coherent_dma_mask;
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 484c558c63a6..6067f6423674 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -19,6 +19,7 @@
#include <linux/slab.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_iommu.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
@@ -162,25 +163,37 @@ EXPORT_SYMBOL(of_device_alloc);
*/
static void of_dma_configure(struct platform_device *pdev)
{
- u64 dma_addr, paddr, size;
+ u64 dma_addr, paddr, size, mask;
int ret;
bool coherent;
unsigned long offset;
+ struct iommu_dma_mapping *iommu;
struct device *dev = &pdev->dev;
+ /*
+ * Set default dma-mask to 32 bit. Drivers are expected to setup
+ * the correct supported dma_mask.
+ */
+ mask = DMA_BIT_MASK(32);
+
ret = of_dma_get_range(dev->of_node, &dma_addr, &paddr, &size);
- offset = ret < 0 ? 0 : PFN_DOWN(paddr - dma_addr);
- dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset);
+ if (ret < 0) {
+ dma_addr = offset = 0;
+ size = mask;
+ } else {
+ offset = PFN_DOWN(paddr - dma_addr);
+ dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset);
+ }
coherent = of_dma_is_coherent(dev->of_node);
dev_dbg(dev, "device is%sdma coherent\n",
coherent ? " " : " not ");
- /*
- * Set default dma-mask to 32 bit. Drivers are expected to setup
- * the correct supported dma_mask.
- */
- arch_setup_dma_ops(dev, DMA_BIT_MASK(32), offset, coherent);
+ iommu = of_iommu_configure(dev);
+ dev_dbg(dev, "device is%sbehind an iommu\n",
+ iommu ? " " : " not ");
+
+ arch_setup_dma_ops(dev, mask, dma_addr, size, offset, iommu, coherent);
}
/**
@@ -209,14 +222,9 @@ static struct platform_device *of_platform_device_create_pdata(
if (!dev)
goto err_clear_flag;
- of_dma_configure(dev);
dev->dev.bus = &platform_bus_type;
dev->dev.platform_data = platform_data;
-
- /* We do not fill the DMA ops for platform devices by default.
- * This is currently the responsibility of the platform code
- * to do such, possibly using a device notifier
- */
+ of_dma_configure(dev);
if (of_device_add(dev) != 0) {
platform_device_put(dev);
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 16bf92f71c3e..19a31f55a5d0 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -138,7 +138,10 @@ extern u64 dma_get_required_mask(struct device *dev);
#ifndef arch_setup_dma_ops
static inline void arch_setup_dma_ops(struct device *dev, u64 mask,
- unsigned long offset, bool coherent) { }
+ u64 dma_base, u64 size,
+ unsigned long offset,
+ struct iommu_dma_mapping *iommu,
+ bool coherent) { }
#endif
static inline unsigned int dma_get_max_seg_size(struct device *dev)
--
2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 5/7] dma-mapping: detect and configure IOMMU in of_dma_configure
Date: Tue, 2 Sep 2014 18:56:25 +0100 [thread overview]
Message-ID: <1409680587-29818-6-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1409680587-29818-1-git-send-email-will.deacon@arm.com>
This patch extends of_dma_configure so that it sets up the IOMMU for a
device, as well as the coherent/non-coherent DMA mapping ops.
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/include/asm/dma-mapping.h | 5 ++++-
drivers/of/platform.c | 36 ++++++++++++++++++++++--------------
include/linux/dma-mapping.h | 5 ++++-
3 files changed, 30 insertions(+), 16 deletions(-)
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
index dad006dabbe6..788b8eef40e8 100644
--- a/arch/arm/include/asm/dma-mapping.h
+++ b/arch/arm/include/asm/dma-mapping.h
@@ -122,7 +122,10 @@ static inline unsigned long dma_max_pfn(struct device *dev)
#define dma_max_pfn(dev) dma_max_pfn(dev)
static inline void arch_setup_dma_ops(struct device *dev, u64 mask,
- unsigned long offset, bool coherent)
+ u64 dma_base, u64 size,
+ unsigned long offset,
+ struct iommu_dma_mapping *iommu,
+ bool coherent)
{
dev->coherent_dma_mask = mask;
dev->dma_mask = &dev->coherent_dma_mask;
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 484c558c63a6..6067f6423674 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -19,6 +19,7 @@
#include <linux/slab.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
+#include <linux/of_iommu.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
@@ -162,25 +163,37 @@ EXPORT_SYMBOL(of_device_alloc);
*/
static void of_dma_configure(struct platform_device *pdev)
{
- u64 dma_addr, paddr, size;
+ u64 dma_addr, paddr, size, mask;
int ret;
bool coherent;
unsigned long offset;
+ struct iommu_dma_mapping *iommu;
struct device *dev = &pdev->dev;
+ /*
+ * Set default dma-mask to 32 bit. Drivers are expected to setup
+ * the correct supported dma_mask.
+ */
+ mask = DMA_BIT_MASK(32);
+
ret = of_dma_get_range(dev->of_node, &dma_addr, &paddr, &size);
- offset = ret < 0 ? 0 : PFN_DOWN(paddr - dma_addr);
- dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset);
+ if (ret < 0) {
+ dma_addr = offset = 0;
+ size = mask;
+ } else {
+ offset = PFN_DOWN(paddr - dma_addr);
+ dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset);
+ }
coherent = of_dma_is_coherent(dev->of_node);
dev_dbg(dev, "device is%sdma coherent\n",
coherent ? " " : " not ");
- /*
- * Set default dma-mask to 32 bit. Drivers are expected to setup
- * the correct supported dma_mask.
- */
- arch_setup_dma_ops(dev, DMA_BIT_MASK(32), offset, coherent);
+ iommu = of_iommu_configure(dev);
+ dev_dbg(dev, "device is%sbehind an iommu\n",
+ iommu ? " " : " not ");
+
+ arch_setup_dma_ops(dev, mask, dma_addr, size, offset, iommu, coherent);
}
/**
@@ -209,14 +222,9 @@ static struct platform_device *of_platform_device_create_pdata(
if (!dev)
goto err_clear_flag;
- of_dma_configure(dev);
dev->dev.bus = &platform_bus_type;
dev->dev.platform_data = platform_data;
-
- /* We do not fill the DMA ops for platform devices by default.
- * This is currently the responsibility of the platform code
- * to do such, possibly using a device notifier
- */
+ of_dma_configure(dev);
if (of_device_add(dev) != 0) {
platform_device_put(dev);
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 16bf92f71c3e..19a31f55a5d0 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -138,7 +138,10 @@ extern u64 dma_get_required_mask(struct device *dev);
#ifndef arch_setup_dma_ops
static inline void arch_setup_dma_ops(struct device *dev, u64 mask,
- unsigned long offset, bool coherent) { }
+ u64 dma_base, u64 size,
+ unsigned long offset,
+ struct iommu_dma_mapping *iommu,
+ bool coherent) { }
#endif
static inline unsigned int dma_get_max_seg_size(struct device *dev)
--
2.1.0
next prev parent reply other threads:[~2014-09-02 17:56 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 17:56 [RFC PATCH v2 0/7] Introduce automatic DMA configuration for IOMMU masters Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 17:56 ` [RFC PATCH v2 1/7] iommu: provide early initialisation hook for IOMMU drivers Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-10 11:29 ` Marek Szyprowski
2014-09-10 11:29 ` Marek Szyprowski
2014-09-02 17:56 ` [RFC PATCH v2 2/7] dma-mapping: replace set_arch_dma_coherent_ops with arch_setup_dma_ops Will Deacon
2014-09-02 17:56 ` Will Deacon
2014-09-05 15:37 ` Grygorii Strashko
2014-09-05 15:37 ` Grygorii Strashko
[not found] ` <5409D8C5.9010804-l0cyMroinI0@public.gmane.org>
2014-09-08 10:31 ` Will Deacon
2014-09-08 10:31 ` Will Deacon
[not found] ` <20140908103129.GC26030-5wv7dgnIgG8@public.gmane.org>
2014-09-09 14:15 ` Grygorii Strashko
2014-09-09 14:15 ` Grygorii Strashko
2014-09-02 17:56 ` [RFC PATCH v2 3/7] iommu: add new iommu_ops callback for adding an OF device Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-4-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-10 11:16 ` Marek Szyprowski
2014-09-10 11:16 ` Marek Szyprowski
[not found] ` <541032F6.1090809-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-10 11:22 ` Will Deacon
2014-09-10 11:22 ` Will Deacon
[not found] ` <20140910112213.GH28488-5wv7dgnIgG8@public.gmane.org>
2014-09-10 11:33 ` Will Deacon
2014-09-10 11:33 ` Will Deacon
2014-09-02 17:56 ` [RFC PATCH v2 4/7] iommu: provide helper function to configure an IOMMU for an of master Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-5-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 19:10 ` Arnd Bergmann
2014-09-02 19:10 ` Arnd Bergmann
2014-09-04 11:26 ` Will Deacon
2014-09-04 11:26 ` Will Deacon
2014-09-04 11:59 ` Arnd Bergmann
2014-09-04 11:59 ` Arnd Bergmann
2014-09-04 12:28 ` Will Deacon
2014-09-04 12:28 ` Will Deacon
2014-09-10 13:01 ` Laurent Pinchart
2014-09-10 13:01 ` Laurent Pinchart
2014-09-10 13:06 ` Will Deacon
2014-09-10 13:06 ` Will Deacon
2014-09-02 17:56 ` Will Deacon [this message]
2014-09-02 17:56 ` [RFC PATCH v2 5/7] dma-mapping: detect and configure IOMMU in of_dma_configure Will Deacon
2014-09-02 17:56 ` [RFC PATCH v2 6/7] arm: call iommu_init before of_platform_populate Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-7-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 18:13 ` Arnd Bergmann
2014-09-02 18:13 ` Arnd Bergmann
2014-09-02 17:56 ` [RFC PATCH v2 7/7] arm: dma-mapping: plumb our iommu mapping ops into arch_setup_dma_ops Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-8-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 18:14 ` Arnd Bergmann
2014-09-02 18:14 ` Arnd Bergmann
2014-09-02 19:11 ` [RFC PATCH v2 0/7] Introduce automatic DMA configuration for IOMMU masters Arnd Bergmann
2014-09-02 19:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409680587-29818-6-git-send-email-will.deacon@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.