From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: "jroedel-l3A5Bk7waGM@public.gmane.org"
<jroedel-l3A5Bk7waGM@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org"
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
"Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
<Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [RFC PATCH v2 3/7] iommu: add new iommu_ops callback for adding an OF device
Date: Wed, 10 Sep 2014 12:33:07 +0100 [thread overview]
Message-ID: <20140910113306.GI28488@arm.com> (raw)
In-Reply-To: <20140910112213.GH28488-5wv7dgnIgG8@public.gmane.org>
On Wed, Sep 10, 2014 at 12:22:13PM +0100, Will Deacon wrote:
> On Wed, Sep 10, 2014 at 12:16:06PM +0100, Marek Szyprowski wrote:
> > On 2014-09-02 19:56, Will Deacon wrote:
> > > +#ifdef CONFIG_OF_IOMMU
> > > + int (*of_xlate)(struct device *dev, struct of_phandle_args *args);
> >
> > If I understand correctly how it is designed to work, then it should be:
> >
> > struct iommu_data *(*of_xlate)(struct device *dev, struct
> > of_phandle_args *args);
>
> Yeah, that might be cleaner than the of_iommu_get_data call in
> of_dma_configure. I'm currently cooking a v3, so I'll include this change.
Actually, I spoke too soon. If we make of_xlate return the iommu_data, then
we have to continue getting the iommu_ops from the bus_type, otherwise we
have no way to call the right of_xlate.
So I'd rather leave of_dma_configure using of_iommu_get_data (I'm currently
ripping out the bus code in there) so that we can embed the iommu_ops in
iommu_data instead.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 3/7] iommu: add new iommu_ops callback for adding an OF device
Date: Wed, 10 Sep 2014 12:33:07 +0100 [thread overview]
Message-ID: <20140910113306.GI28488@arm.com> (raw)
In-Reply-To: <20140910112213.GH28488@arm.com>
On Wed, Sep 10, 2014 at 12:22:13PM +0100, Will Deacon wrote:
> On Wed, Sep 10, 2014 at 12:16:06PM +0100, Marek Szyprowski wrote:
> > On 2014-09-02 19:56, Will Deacon wrote:
> > > +#ifdef CONFIG_OF_IOMMU
> > > + int (*of_xlate)(struct device *dev, struct of_phandle_args *args);
> >
> > If I understand correctly how it is designed to work, then it should be:
> >
> > struct iommu_data *(*of_xlate)(struct device *dev, struct
> > of_phandle_args *args);
>
> Yeah, that might be cleaner than the of_iommu_get_data call in
> of_dma_configure. I'm currently cooking a v3, so I'll include this change.
Actually, I spoke too soon. If we make of_xlate return the iommu_data, then
we have to continue getting the iommu_ops from the bus_type, otherwise we
have no way to call the right of_xlate.
So I'd rather leave of_dma_configure using of_iommu_get_data (I'm currently
ripping out the bus code in there) so that we can embed the iommu_ops in
iommu_data instead.
Will
next prev parent reply other threads:[~2014-09-10 11:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 17:56 [RFC PATCH v2 0/7] Introduce automatic DMA configuration for IOMMU masters Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 17:56 ` [RFC PATCH v2 1/7] iommu: provide early initialisation hook for IOMMU drivers Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-10 11:29 ` Marek Szyprowski
2014-09-10 11:29 ` Marek Szyprowski
2014-09-02 17:56 ` [RFC PATCH v2 2/7] dma-mapping: replace set_arch_dma_coherent_ops with arch_setup_dma_ops Will Deacon
2014-09-02 17:56 ` Will Deacon
2014-09-05 15:37 ` Grygorii Strashko
2014-09-05 15:37 ` Grygorii Strashko
[not found] ` <5409D8C5.9010804-l0cyMroinI0@public.gmane.org>
2014-09-08 10:31 ` Will Deacon
2014-09-08 10:31 ` Will Deacon
[not found] ` <20140908103129.GC26030-5wv7dgnIgG8@public.gmane.org>
2014-09-09 14:15 ` Grygorii Strashko
2014-09-09 14:15 ` Grygorii Strashko
2014-09-02 17:56 ` [RFC PATCH v2 3/7] iommu: add new iommu_ops callback for adding an OF device Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-4-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-10 11:16 ` Marek Szyprowski
2014-09-10 11:16 ` Marek Szyprowski
[not found] ` <541032F6.1090809-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-10 11:22 ` Will Deacon
2014-09-10 11:22 ` Will Deacon
[not found] ` <20140910112213.GH28488-5wv7dgnIgG8@public.gmane.org>
2014-09-10 11:33 ` Will Deacon [this message]
2014-09-10 11:33 ` Will Deacon
2014-09-02 17:56 ` [RFC PATCH v2 4/7] iommu: provide helper function to configure an IOMMU for an of master Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-5-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 19:10 ` Arnd Bergmann
2014-09-02 19:10 ` Arnd Bergmann
2014-09-04 11:26 ` Will Deacon
2014-09-04 11:26 ` Will Deacon
2014-09-04 11:59 ` Arnd Bergmann
2014-09-04 11:59 ` Arnd Bergmann
2014-09-04 12:28 ` Will Deacon
2014-09-04 12:28 ` Will Deacon
2014-09-10 13:01 ` Laurent Pinchart
2014-09-10 13:01 ` Laurent Pinchart
2014-09-10 13:06 ` Will Deacon
2014-09-10 13:06 ` Will Deacon
2014-09-02 17:56 ` [RFC PATCH v2 5/7] dma-mapping: detect and configure IOMMU in of_dma_configure Will Deacon
2014-09-02 17:56 ` Will Deacon
2014-09-02 17:56 ` [RFC PATCH v2 6/7] arm: call iommu_init before of_platform_populate Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-7-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 18:13 ` Arnd Bergmann
2014-09-02 18:13 ` Arnd Bergmann
2014-09-02 17:56 ` [RFC PATCH v2 7/7] arm: dma-mapping: plumb our iommu mapping ops into arch_setup_dma_ops Will Deacon
2014-09-02 17:56 ` Will Deacon
[not found] ` <1409680587-29818-8-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-09-02 18:14 ` Arnd Bergmann
2014-09-02 18:14 ` Arnd Bergmann
2014-09-02 19:11 ` [RFC PATCH v2 0/7] Introduce automatic DMA configuration for IOMMU masters Arnd Bergmann
2014-09-02 19:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910113306.GI28488@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.