All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Yigal Korman <yigal@plexistor.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	akpm@linuxfoundation.org, Arnd Bergmann <arnd@arndb.de>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Stefan Bader <stefan.bader@canonical.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 4/5] x86, mm: Add set_memory_wt() for WT
Date: Mon, 08 Sep 2014 09:07:43 -0600	[thread overview]
Message-ID: <1410188863.28990.209.camel@misato.fc.hp.com> (raw)
In-Reply-To: <CALCETrX-jsDBbPTVBLE=TkrfO9dLJgpog7TVKqi-wxxj6saRjA@mail.gmail.com>

On Sun, 2014-09-07 at 09:49 -0700, Andy Lutomirski wrote:
> On Sun, Sep 7, 2014 at 1:49 AM, Yigal Korman <yigal@plexistor.com> wrote:
> > I think that what confused Andy (or at least me) is the documentation in Documentation/x86/pat.txt
> > If it's possible, can you please update pat.txt as part of the patch?
> 
> Indeed.  That file seems to indicate several times that the intended
> use of set_memory_xyz is for RAM.


Good point.  pat.txt is correct that the "intended" use of
set_memory_xyz() is for RAM since there is no other way to set non-WB
attribute for RAM.  For reserved memory, one should call ioremap_xyz()
to map with the xyz attribute directly.  From the functionality POV,
set_memory_xyz() works for reserved memory, but such usage is not
intended.

Should I drop the patch 4/5 until we can track the use of WT for RAM?

Thanks,
-Toshi
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Yigal Korman <yigal@plexistor.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	akpm@linuxfoundation.org, Arnd Bergmann <arnd@arndb.de>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Stefan Bader <stefan.bader@canonical.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 4/5] x86, mm: Add set_memory_wt() for WT
Date: Mon, 08 Sep 2014 09:07:43 -0600	[thread overview]
Message-ID: <1410188863.28990.209.camel@misato.fc.hp.com> (raw)
In-Reply-To: <CALCETrX-jsDBbPTVBLE=TkrfO9dLJgpog7TVKqi-wxxj6saRjA@mail.gmail.com>

On Sun, 2014-09-07 at 09:49 -0700, Andy Lutomirski wrote:
> On Sun, Sep 7, 2014 at 1:49 AM, Yigal Korman <yigal@plexistor.com> wrote:
> > I think that what confused Andy (or at least me) is the documentation in Documentation/x86/pat.txt
> > If it's possible, can you please update pat.txt as part of the patch?
> 
> Indeed.  That file seems to indicate several times that the intended
> use of set_memory_xyz is for RAM.


Good point.  pat.txt is correct that the "intended" use of
set_memory_xyz() is for RAM since there is no other way to set non-WB
attribute for RAM.  For reserved memory, one should call ioremap_xyz()
to map with the xyz attribute directly.  From the functionality POV,
set_memory_xyz() works for reserved memory, but such usage is not
intended.

Should I drop the patch 4/5 until we can track the use of WT for RAM?

Thanks,
-Toshi
 


  reply	other threads:[~2014-09-08 15:18 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 18:35 [PATCH 0/5] Support Write-Through mapping on x86 Toshi Kani
2014-09-04 18:35 ` Toshi Kani
2014-09-04 18:35 ` [PATCH 1/5] x86, mm, pat: Set WT to PA4 slot of PAT MSR Toshi Kani
2014-09-04 18:35   ` Toshi Kani
2014-09-04 20:11   ` Henrique de Moraes Holschuh
2014-09-04 20:11     ` Henrique de Moraes Holschuh
2014-09-04 20:21     ` H. Peter Anvin
2014-09-04 20:21       ` H. Peter Anvin
2014-09-04 23:19       ` Henrique de Moraes Holschuh
2014-09-04 23:19         ` Henrique de Moraes Holschuh
2014-09-04 23:34         ` Andy Lutomirski
2014-09-04 23:34           ` Andy Lutomirski
2014-09-05  0:29           ` Toshi Kani
2014-09-05  0:29             ` Toshi Kani
2014-09-05  0:51             ` Andy Lutomirski
2014-09-05  0:51               ` Andy Lutomirski
2014-09-05 14:00               ` Toshi Kani
2014-09-05 14:00                 ` Toshi Kani
2014-09-05 15:07                 ` H. Peter Anvin
2014-09-05 15:07                   ` H. Peter Anvin
2014-09-05 15:22                   ` Toshi Kani
2014-09-05 15:22                     ` Toshi Kani
2014-09-05 15:41                     ` H. Peter Anvin
2014-09-05 15:41                       ` H. Peter Anvin
2014-09-05 15:42                       ` Toshi Kani
2014-09-05 15:42                         ` Toshi Kani
2014-09-12 19:25           ` Konrad Rzeszutek Wilk
2014-09-12 19:25             ` Konrad Rzeszutek Wilk
2014-09-12 20:03             ` Andy Lutomirski
2014-09-12 20:03               ` Andy Lutomirski
2014-09-12 20:21               ` Konrad Rzeszutek Wilk
2014-09-12 20:21                 ` Konrad Rzeszutek Wilk
2014-09-04 20:31     ` Toshi Kani
2014-09-04 20:31       ` Toshi Kani
2014-09-04 20:50       ` Andy Lutomirski
2014-09-04 20:50         ` Andy Lutomirski
2014-09-04 23:27       ` Toshi Kani
2014-09-04 23:27         ` Toshi Kani
2014-09-05 10:23         ` Ingo Molnar
2014-09-05 10:23           ` Ingo Molnar
2014-09-05 13:50           ` Toshi Kani
2014-09-05 13:50             ` Toshi Kani
2014-09-07 13:58             ` Henrique de Moraes Holschuh
2014-09-07 13:58               ` Henrique de Moraes Holschuh
2014-09-04 18:35 ` [PATCH 2/5] x86, mm, pat: Change reserve_memtype() to handle WT Toshi Kani
2014-09-04 18:35   ` Toshi Kani
2014-09-04 18:35 ` [PATCH 3/5] x86, mm, asm-gen: Add ioremap_wt() for WT Toshi Kani
2014-09-04 18:35   ` Toshi Kani
2014-09-04 18:35 ` [PATCH 4/5] x86, mm: Add set_memory_wt() " Toshi Kani
2014-09-04 18:35   ` Toshi Kani
2014-09-04 18:57   ` Andy Lutomirski
2014-09-04 18:57     ` Andy Lutomirski
2014-09-04 18:57     ` Toshi Kani
2014-09-04 18:57       ` Toshi Kani
2014-09-04 19:14       ` Andy Lutomirski
2014-09-04 19:14         ` Andy Lutomirski
2014-09-04 19:30         ` Toshi Kani
2014-09-07  8:49       ` Yigal Korman
2014-09-07  8:49         ` Yigal Korman
2014-09-07 16:49         ` Andy Lutomirski
2014-09-07 16:49           ` Andy Lutomirski
2014-09-08 15:07           ` Toshi Kani [this message]
2014-09-08 15:07             ` Toshi Kani
2014-09-08 17:23             ` Andy Lutomirski
2014-09-08 17:23               ` Andy Lutomirski
2014-09-08 18:42               ` Toshi Kani
2014-09-08 18:42                 ` Toshi Kani
2014-09-04 18:35 ` [PATCH 5/5] x86, mm, pat: Add pgprot_writethrough() " Toshi Kani
2014-09-04 18:35   ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410188863.28990.209.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=akpm@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=stefan.bader@canonical.com \
    --cc=tglx@linutronix.de \
    --cc=yigal@plexistor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.