All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Frediano Ziglio <freddy77@gmail.com>
Cc: Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@linaro.org>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: add support for early printk for HiSilicon D01 platform
Date: Fri, 3 Oct 2014 11:29:41 +0100	[thread overview]
Message-ID: <1412332181.12695.0.camel@citrix.com> (raw)
In-Reply-To: <CAHt6W4fZJJPZ-5iba40WyQwXqUSYniA7szHzTNC+H42Bp2E=VA@mail.gmail.com>

On Thu, 2014-10-02 at 16:48 +0100, Frediano Ziglio wrote:
> This platform use a standard 8250 device on port 0xe4007000.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>

Acked + applied.

For some reason this didn't hit the list when you posted. Did you get a
bounce? The address looks correct.

NB: if you want the commit author to match your s-o-b and you aren't
sending from your S-o-b address then you need to include a From:
pseudoheader with the "author address".

> ---
>  docs/misc/arm/early-printk.txt | 1 +
>  xen/arch/arm/Rules.mk          | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
> index 1431751..92ab0df 100644
> --- a/docs/misc/arm/early-printk.txt
> +++ b/docs/misc/arm/early-printk.txt
> @@ -16,6 +16,7 @@ where mach is the name of the machine:
>    - omap5432: printk with UART3 on TI OMAP5432 processors
>    - sun6i: printk with 8250 on Allwinner A31 processors
>    - sun7i: printk with 8250 on Allwinner A20 processors
> +  - hip04-d01: printk with 8250 on HiSilicon Hip-04 D01
> 
>  The base address and baud rate is hardcoded in xen/arch/arm/Rules.mk,
>  see there when adding support for new machines.
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index 26fafa2..15f8b09 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -100,6 +100,12 @@ EARLY_PRINTK_INC := pl011
>  EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x7ff80000
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), hip04-d01)
> +EARLY_PRINTK_INC := 8250
> +EARLY_PRINTK_BAUD := 115200
> +EARLY_UART_BASE_ADDRESS := 0xE4007000
> +EARLY_UART_REG_SHIFT := 2
> +endif
> 
>  ifneq ($(EARLY_PRINTK_INC),)
>  EARLY_PRINTK := y

  reply	other threads:[~2014-10-03 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 15:48 [PATCH] xen/arm: add support for early printk for HiSilicon D01 platform Frediano Ziglio
2014-10-03 10:29 ` Ian Campbell [this message]
2014-10-03 10:44   ` Frediano Ziglio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412332181.12695.0.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=freddy77@gmail.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.