[PATCH] xen/arm: add support for early printk for HiSilicon D01 platform

[PATCH] xen/arm: add support for early printk for HiSilicon D01 platform

[Frediano Ziglio]

This platform use a standard 8250 device on port 0xe4007000.

Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
---
 docs/misc/arm/early-printk.txt | 1 +
 xen/arch/arm/Rules.mk          | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
index 1431751..92ab0df 100644
--- a/docs/misc/arm/early-printk.txt
+++ b/docs/misc/arm/early-printk.txt
@@ -16,6 +16,7 @@ where mach is the name of the machine:
   - omap5432: printk with UART3 on TI OMAP5432 processors
   - sun6i: printk with 8250 on Allwinner A31 processors
   - sun7i: printk with 8250 on Allwinner A20 processors
+  - hip04-d01: printk with 8250 on HiSilicon Hip-04 D01

 The base address and baud rate is hardcoded in xen/arch/arm/Rules.mk,
 see there when adding support for new machines.
diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index 26fafa2..15f8b09 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -100,6 +100,12 @@ EARLY_PRINTK_INC := pl011
 EARLY_PRINTK_BAUD := 115200
 EARLY_UART_BASE_ADDRESS := 0x7ff80000
 endif
+ifeq ($(CONFIG_EARLY_PRINTK), hip04-d01)
+EARLY_PRINTK_INC := 8250
+EARLY_PRINTK_BAUD := 115200
+EARLY_UART_BASE_ADDRESS := 0xE4007000
+EARLY_UART_REG_SHIFT := 2
+endif

 ifneq ($(EARLY_PRINTK_INC),)
 EARLY_PRINTK := y
-- 
1.9.1

Re: [PATCH] xen/arm: add support for early printk for HiSilicon D01 platform

[Ian Campbell]

On Thu, 2014-10-02 at 16:48 +0100, Frediano Ziglio wrote:
> This platform use a standard 8250 device on port 0xe4007000.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>

Acked + applied.

For some reason this didn't hit the list when you posted. Did you get a
bounce? The address looks correct.

NB: if you want the commit author to match your s-o-b and you aren't
sending from your S-o-b address then you need to include a From:
pseudoheader with the "author address".

> ---
>  docs/misc/arm/early-printk.txt | 1 +
>  xen/arch/arm/Rules.mk          | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
> index 1431751..92ab0df 100644
> --- a/docs/misc/arm/early-printk.txt
> +++ b/docs/misc/arm/early-printk.txt
> @@ -16,6 +16,7 @@ where mach is the name of the machine:
>    - omap5432: printk with UART3 on TI OMAP5432 processors
>    - sun6i: printk with 8250 on Allwinner A31 processors
>    - sun7i: printk with 8250 on Allwinner A20 processors
> +  - hip04-d01: printk with 8250 on HiSilicon Hip-04 D01
> 
>  The base address and baud rate is hardcoded in xen/arch/arm/Rules.mk,
>  see there when adding support for new machines.
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index 26fafa2..15f8b09 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -100,6 +100,12 @@ EARLY_PRINTK_INC := pl011
>  EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x7ff80000
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), hip04-d01)
> +EARLY_PRINTK_INC := 8250
> +EARLY_PRINTK_BAUD := 115200
> +EARLY_UART_BASE_ADDRESS := 0xE4007000
> +EARLY_UART_REG_SHIFT := 2
> +endif
> 
>  ifneq ($(EARLY_PRINTK_INC),)
>  EARLY_PRINTK := y

Re: [PATCH] xen/arm: add support for early printk for HiSilicon D01 platform

[Frediano Ziglio]

2014-10-03 11:29 GMT+01:00 Ian Campbell <Ian.Campbell@citrix.com>:
> On Thu, 2014-10-02 at 16:48 +0100, Frediano Ziglio wrote:
>> This platform use a standard 8250 device on port 0xe4007000.
>>
>> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
>
> Acked + applied.
>
> For some reason this didn't hit the list when you posted. Did you get a
> bounce? The address looks correct.
>

Weird. I even check my spam folder but didn't find any bounce or error
of any sort. Could be that was marked as spam by the mailing list
filter?

> NB: if you want the commit author to match your s-o-b and you aren't
> sending from your S-o-b address then you need to include a From:
> pseudoheader with the "author address".
>

I'll try to remember. Not that really matter anyway, it's still me :)

Frediano

>> ---
>>  docs/misc/arm/early-printk.txt | 1 +
>>  xen/arch/arm/Rules.mk          | 6 ++++++
>>  2 files changed, 7 insertions(+)
>>
>> diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
>> index 1431751..92ab0df 100644
>> --- a/docs/misc/arm/early-printk.txt
>> +++ b/docs/misc/arm/early-printk.txt
>> @@ -16,6 +16,7 @@ where mach is the name of the machine:
>>    - omap5432: printk with UART3 on TI OMAP5432 processors
>>    - sun6i: printk with 8250 on Allwinner A31 processors
>>    - sun7i: printk with 8250 on Allwinner A20 processors
>> +  - hip04-d01: printk with 8250 on HiSilicon Hip-04 D01
>>
>>  The base address and baud rate is hardcoded in xen/arch/arm/Rules.mk,
>>  see there when adding support for new machines.
>> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
>> index 26fafa2..15f8b09 100644
>> --- a/xen/arch/arm/Rules.mk
>> +++ b/xen/arch/arm/Rules.mk
>> @@ -100,6 +100,12 @@ EARLY_PRINTK_INC := pl011
>>  EARLY_PRINTK_BAUD := 115200
>>  EARLY_UART_BASE_ADDRESS := 0x7ff80000
>>  endif
>> +ifeq ($(CONFIG_EARLY_PRINTK), hip04-d01)
>> +EARLY_PRINTK_INC := 8250
>> +EARLY_PRINTK_BAUD := 115200
>> +EARLY_UART_BASE_ADDRESS := 0xE4007000
>> +EARLY_UART_REG_SHIFT := 2
>> +endif
>>
>>  ifneq ($(EARLY_PRINTK_INC),)
>>  EARLY_PRINTK := y
>
>
>