Re: [PATCH] tools/hotplug/Linux: Fix build

[Ian Campbell <Ian.Campbell@citrix.com>]

On Fri, 2014-10-10 at 09:35 +0100, Ian Campbell wrote:
> On Thu, 2014-10-09 at 17:58 +0100, Andrew Cooper wrote:
> > On 09/10/14 17:54, Olaf Hering wrote:
> > > On Thu, Oct 09, Anthony PERARD wrote:
> > >
> > >> make[6]: Entering directory '/build/xen-unstable/src/xen-unstable/tools/hotplug/Linux'
> > >> [...]
> > >> make -C systemd all
> > >> make -C systemd install
> > > I wonder why that happens anyway, isnt that the bug? Shouldnt some "all"
> > > depend on "install", or whatever?
> > >
> > > Olaf
> > 
> > all: should never depend on install.
> > 
> > all: will be the default target from `make`, which is expected to build
> > components, and is specifically separate from `make install DESTDIR=$foo`
> 
> That's true, and as such Olaf's eac3f5122fd4769b2885d8ad78bcbcf5df2472c1
> is of course not correct, somehow I didn't manage to notice this.
> 
> I intend to revert shortly...

I've just pushed the following.

I expect the actual problem is that the buildsystem is recusing into
this directory twice simultaneously for "all" and "install" at the same
time. That seems likely to be an issue with the Makefile in the parent
directory.

Should subdirs-install depend on subdirs-all perhaps?

commit 66bb8b04f0032ddf0aa007b0850be1ec15477d60
Author: Ian Campbell <ian.campbell@citrix.com>
Date:   Fri Oct 10 09:35:34 2014 +0100

    Revert "tools/hotplug: fix race during xen.conf creation"
    
    This reverts commit eac3f5122fd4769b2885d8ad78bcbcf5df2472c1.
    
    The "all" target should never depend on "install", it is supposed to only build
    not install.
    
    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
index 6950d24..9c58b33 100644
--- a/tools/hotplug/Linux/systemd/Makefile
+++ b/tools/hotplug/Linux/systemd/Makefile
@@ -21,11 +21,10 @@ ALL_XEN_SYSTEMD =	$(XEN_SYSTEMD_MODULES)  \
 			$(XEN_SYSTEMD_SERVICE)
 
 .PHONY: all
-all:	install
+all:	$(ALL_XEN_SYSTEMD)
 
 .PHONY: clean
 clean:
-	rm -f $(ALL_XEN_SYSTEMD)
 
 .PHONY: install
 install: $(ALL_XEN_SYSTEMD)


> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel