All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Olaf Hering <olaf@aepfle.de>, Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH V2] tools/hotplug: Removing of "all" dependency from "install" rule.
Date: Tue, 14 Oct 2014 10:58:50 +0100	[thread overview]
Message-ID: <1413280730.1497.30.camel@citrix.com> (raw)
In-Reply-To: <21563.61232.501986.998042@mariner.uk.xensource.com>

On Mon, 2014-10-13 at 16:26 +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH V2] tools/hotplug: Removing of "all" dependency from "install" rule."):
> > The "install" rules depends on both "all" and "subdirs-install" and
> > "all" depends on "subdirs-all". This leads the "install" rules to call
> > both "subdirs-all" and "subdirs-install" which create a race with two
> > concurrent `make` within the same directory (systemd) trying to make the
> > same things (xen.conf) and failing.
> 
> Thanks for the investigation.  I think this demonstrates that our
> approach to subdirs is, at the very least, excessively fragile.  But
> this fix (or workaround, if we prefer) will do.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Likewise, and applied.

Ian.

  reply	other threads:[~2014-10-14  9:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 16:35 [PATCH] tools/hotplug/Linux: Fix build Anthony PERARD
2014-10-09 16:53 ` Olaf Hering
2014-10-09 16:54 ` Olaf Hering
2014-10-09 16:58   ` Andrew Cooper
2014-10-10  8:35     ` Ian Campbell
2014-10-10  8:44       ` Ian Campbell
2014-10-10  9:19         ` Wei Liu
2014-10-10  9:20           ` Ian Campbell
2014-10-10 10:03             ` Olaf Hering
2014-10-10  9:59         ` Olaf Hering
2014-10-10 10:42           ` Anthony PERARD
2014-10-10 11:19             ` Olaf Hering
2014-10-10 14:20               ` Anthony PERARD
2014-10-10 14:28                 ` Olaf Hering
2014-10-10 14:31                   ` Ian Campbell
2014-10-10 15:34                     ` Anthony PERARD
2014-10-13 14:31                       ` [PATCH V2] tools/hotplug: Removing of "all" dependency from "install" rule Anthony PERARD
2014-10-13 15:26                         ` Ian Jackson
2014-10-14  9:58                           ` Ian Campbell [this message]
2014-10-14  9:59                           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413280730.1497.30.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.