From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/hotplug/Linux: Fix build
Date: Fri, 10 Oct 2014 12:03:44 +0200 [thread overview]
Message-ID: <20141010100343.GB26050@aepfle.de> (raw)
In-Reply-To: <1412932846.27111.2.camel@citrix.com>
On Fri, Oct 10, Ian Campbell wrote:
> On Fri, 2014-10-10 at 10:19 +0100, Wei Liu wrote:
> > On Fri, Oct 10, 2014 at 09:44:38AM +0100, Ian Campbell wrote:
> > [...]
> > > Should subdirs-install depend on subdirs-all perhaps?
> > >
> > > commit 66bb8b04f0032ddf0aa007b0850be1ec15477d60
> > > Author: Ian Campbell <ian.campbell@citrix.com>
> > > Date: Fri Oct 10 09:35:34 2014 +0100
> > >
> > > Revert "tools/hotplug: fix race during xen.conf creation"
> > >
> > > This reverts commit eac3f5122fd4769b2885d8ad78bcbcf5df2472c1.
> > >
> > > The "all" target should never depend on "install", it is supposed to only build
> > > not install.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > >
> > > diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
> > > index 6950d24..9c58b33 100644
> > > --- a/tools/hotplug/Linux/systemd/Makefile
> > > +++ b/tools/hotplug/Linux/systemd/Makefile
> > > @@ -21,11 +21,10 @@ ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \
> > > $(XEN_SYSTEMD_SERVICE)
> > >
> > > .PHONY: all
> > > -all: install
> > > +all: $(ALL_XEN_SYSTEMD)
> > >
> > > .PHONY: clean
> > > clean:
> > > - rm -f $(ALL_XEN_SYSTEMD)
> > >
> >
> > Now clean target just becomes empty...
>
> ... the perils of lumping multiple changes into a single patch...
And it was wrong anyway because it will wipe everything in that dir. If
at all, it should have been "rm -f $(XEN_SYSTEMD_MODULES)" to wipe the
generated files.
Olaf
next prev parent reply other threads:[~2014-10-10 10:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:35 [PATCH] tools/hotplug/Linux: Fix build Anthony PERARD
2014-10-09 16:53 ` Olaf Hering
2014-10-09 16:54 ` Olaf Hering
2014-10-09 16:58 ` Andrew Cooper
2014-10-10 8:35 ` Ian Campbell
2014-10-10 8:44 ` Ian Campbell
2014-10-10 9:19 ` Wei Liu
2014-10-10 9:20 ` Ian Campbell
2014-10-10 10:03 ` Olaf Hering [this message]
2014-10-10 9:59 ` Olaf Hering
2014-10-10 10:42 ` Anthony PERARD
2014-10-10 11:19 ` Olaf Hering
2014-10-10 14:20 ` Anthony PERARD
2014-10-10 14:28 ` Olaf Hering
2014-10-10 14:31 ` Ian Campbell
2014-10-10 15:34 ` Anthony PERARD
2014-10-13 14:31 ` [PATCH V2] tools/hotplug: Removing of "all" dependency from "install" rule Anthony PERARD
2014-10-13 15:26 ` Ian Jackson
2014-10-14 9:58 ` Ian Campbell
2014-10-14 9:59 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010100343.GB26050@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.