From: yingjoe.chen@mediatek.com (Joe.C)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain.
Date: Mon, 13 Oct 2014 18:43:16 +0800 [thread overview]
Message-ID: <1413196996.23455.9.camel@mtksdaap41> (raw)
In-Reply-To: <5436BF0C.1030508@arm.com>
On Thu, 2014-10-09 at 17:59 +0100, Marc Zyngier wrote:
> On 09/10/14 15:29, Joe.C wrote
> > @@ -952,7 +988,11 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start,
> >
> > gic_irqs -= hwirq_base; /* calculate # of irqs to allocate */
> >
> > - if (of_property_read_u32(node, "arm,routable-irqs",
> > + if (IS_ENABLED(CONFIG_IRQ_DOMAIN_HIERARCHY) &&
> > + of_find_property(node, "arm,irq-domain-hierarchy", NULL))
> > + gic->domain = irq_domain_add_linear(node, gic_irqs,
> > + &gic_irq_domain_hierarchy_ops, gic);
>
> I really think that looking for a property is the wrong thing to do. If
> "node" is non-NULL, then we're pretty sure that we're initializing from
> DT, and that a pure linear domain should be the right thing, leaving the
> legacy stuff for the few non-DT platforms that are still around.
>
> Thanks,
>
> M.
The only reason I introduce "arm,irq-domain-hierarchy" property is
trying to keep original behavior when hierarchy irq domain is not used.
Without this, when a board init GIC with DT, all driver will have to use
devicetree. I'm not sure we want to break things like this. I will
remove this and just use linear for all DT in my next version.
Joe.C
WARNING: multiple messages have this Message-ID (diff)
From: Joe.C <yingjoe.chen@mediatek.com>
To: Marc Zyngier <marc.zyngier@arm.com>, Mark Rutland <mark.rutland@arm.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Sricharan R <r.sricharan@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
"yh.chen@mediatek.com" <yh.chen@mediatek.com>,
"arm@kernel.org" <arm@kernel.org>,
"nathan.chung@mediatek.com" <nathan.chung@mediatek.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <Pawel.Moll@arm.com>, Matt Porter <mporter@linaro.org>,
Marc Carino <marc.ceeeee@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.
Subject: Re: [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain.
Date: Mon, 13 Oct 2014 18:43:16 +0800 [thread overview]
Message-ID: <1413196996.23455.9.camel@mtksdaap41> (raw)
In-Reply-To: <5436BF0C.1030508@arm.com>
On Thu, 2014-10-09 at 17:59 +0100, Marc Zyngier wrote:
> On 09/10/14 15:29, Joe.C wrote
> > @@ -952,7 +988,11 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start,
> >
> > gic_irqs -= hwirq_base; /* calculate # of irqs to allocate */
> >
> > - if (of_property_read_u32(node, "arm,routable-irqs",
> > + if (IS_ENABLED(CONFIG_IRQ_DOMAIN_HIERARCHY) &&
> > + of_find_property(node, "arm,irq-domain-hierarchy", NULL))
> > + gic->domain = irq_domain_add_linear(node, gic_irqs,
> > + &gic_irq_domain_hierarchy_ops, gic);
>
> I really think that looking for a property is the wrong thing to do. If
> "node" is non-NULL, then we're pretty sure that we're initializing from
> DT, and that a pure linear domain should be the right thing, leaving the
> legacy stuff for the few non-DT platforms that are still around.
>
> Thanks,
>
> M.
The only reason I introduce "arm,irq-domain-hierarchy" property is
trying to keep original behavior when hierarchy irq domain is not used.
Without this, when a board init GIC with DT, all driver will have to use
devicetree. I'm not sure we want to break things like this. I will
remove this and just use linear for all DT in my next version.
Joe.C
next prev parent reply other threads:[~2014-10-13 10:43 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:29 [PATCH v3 0/7] ARM: mediatek: Add support for interrupt polarity Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:29 ` [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-13 12:11 ` Marc Zyngier
2014-10-13 12:11 ` Marc Zyngier
2014-10-13 12:11 ` Marc Zyngier
2014-10-13 14:13 ` Jiang Liu
2014-10-13 14:13 ` Jiang Liu
2014-10-13 14:13 ` Jiang Liu
2014-10-09 14:29 ` [PATCH v3 2/7] genirq: Add more helper functions to support stacked irq_chip Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:29 ` [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 17:22 ` Arnd Bergmann
2014-10-09 17:22 ` Arnd Bergmann
2014-10-09 17:22 ` Arnd Bergmann
2014-10-13 10:43 ` Joe.C [this message]
2014-10-13 10:43 ` Joe.C
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:44 ` Marc Zyngier
2014-10-13 9:44 ` Marc Zyngier
2014-10-13 9:44 ` Marc Zyngier
2014-10-09 14:29 ` [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:53 ` Joe.C
2014-10-09 14:53 ` Joe.C
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-09 14:29 ` [PATCH v3 5/7] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:29 ` [PATCH v3 6/7] dt-bindings: add irq domain parent binding Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:29 ` [PATCH v3 7/7] dt-bindings: add bindings for mediatek sysirq Joe.C
2014-10-09 14:29 ` Joe.C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413196996.23455.9.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.