From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check.
Date: Mon, 13 Oct 2014 13:11:50 +0100 [thread overview]
Message-ID: <543BC186.2050701@arm.com> (raw)
In-Reply-To: <1412864980-20273-2-git-send-email-yingjoe.chen@mediatek.com>
On 09/10/14 15:29, Joe.C wrote:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Change virq type from unsigned int to int. Otherwise the return value
> check for irq_domain_alloc_irqs will always pass.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 584be46..dd8d3ab 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
> struct irq_domain *domain;
> irq_hw_number_t hwirq;
> unsigned int type = IRQ_TYPE_NONE;
> - unsigned int virq;
> + int virq;
>
> domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain;
> if (!domain) {
>
I'd expect this patch to get folded into Jiang's series.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: "Joe.C" <yingjoe.chen@mediatek.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>
Cc: "arm@kernel.org" <arm@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
"hc.yen@mediatek.com" <hc.yen@mediatek.com>,
"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
"nathan.chung@mediatek.com" <nathan.chung@mediatek.com>,
"yh.chen@mediatek.com" <yh.chen@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Pawel Moll <Pawel.Moll@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Matt Porter <mporter@linaro.org>,
Marc Carino <marc.ceeeee@gmail.co>
Subject: Re: [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check.
Date: Mon, 13 Oct 2014 13:11:50 +0100 [thread overview]
Message-ID: <543BC186.2050701@arm.com> (raw)
In-Reply-To: <1412864980-20273-2-git-send-email-yingjoe.chen@mediatek.com>
On 09/10/14 15:29, Joe.C wrote:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Change virq type from unsigned int to int. Otherwise the return value
> check for irq_domain_alloc_irqs will always pass.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 584be46..dd8d3ab 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
> struct irq_domain *domain;
> irq_hw_number_t hwirq;
> unsigned int type = IRQ_TYPE_NONE;
> - unsigned int virq;
> + int virq;
>
> domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain;
> if (!domain) {
>
I'd expect this patch to get folded into Jiang's series.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: "Joe.C" <yingjoe.chen@mediatek.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>
Cc: "arm@kernel.org" <arm@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
"hc.yen@mediatek.com" <hc.yen@mediatek.com>,
"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
"nathan.chung@mediatek.com" <nathan.chung@mediatek.com>,
"yh.chen@mediatek.com" <yh.chen@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Pawel Moll <Pawel.Moll@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Matt Porter <mporter@linaro.org>,
Marc Carino <marc.ceeeee@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Sricharan R <r.sricharan@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check.
Date: Mon, 13 Oct 2014 13:11:50 +0100 [thread overview]
Message-ID: <543BC186.2050701@arm.com> (raw)
In-Reply-To: <1412864980-20273-2-git-send-email-yingjoe.chen@mediatek.com>
On 09/10/14 15:29, Joe.C wrote:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Change virq type from unsigned int to int. Otherwise the return value
> check for irq_domain_alloc_irqs will always pass.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 584be46..dd8d3ab 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -469,7 +469,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
> struct irq_domain *domain;
> irq_hw_number_t hwirq;
> unsigned int type = IRQ_TYPE_NONE;
> - unsigned int virq;
> + int virq;
>
> domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain;
> if (!domain) {
>
I'd expect this patch to get folded into Jiang's series.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-10-13 12:11 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:29 [PATCH v3 0/7] ARM: mediatek: Add support for interrupt polarity Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:29 ` [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-13 12:11 ` Marc Zyngier [this message]
2014-10-13 12:11 ` Marc Zyngier
2014-10-13 12:11 ` Marc Zyngier
2014-10-13 14:13 ` Jiang Liu
2014-10-13 14:13 ` Jiang Liu
2014-10-13 14:13 ` Jiang Liu
2014-10-09 14:29 ` [PATCH v3 2/7] genirq: Add more helper functions to support stacked irq_chip Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:29 ` [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 17:22 ` Arnd Bergmann
2014-10-09 17:22 ` Arnd Bergmann
2014-10-09 17:22 ` Arnd Bergmann
2014-10-13 10:43 ` Joe.C
2014-10-13 10:43 ` Joe.C
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:44 ` Marc Zyngier
2014-10-13 9:44 ` Marc Zyngier
2014-10-13 9:44 ` Marc Zyngier
2014-10-09 14:29 ` [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:53 ` Joe.C
2014-10-09 14:53 ` Joe.C
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-09 14:29 ` [PATCH v3 5/7] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:29 ` [PATCH v3 6/7] dt-bindings: add irq domain parent binding Joe.C
2014-10-09 14:29 ` Joe.C
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:29 ` [PATCH v3 7/7] dt-bindings: add bindings for mediatek sysirq Joe.C
2014-10-09 14:29 ` Joe.C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543BC186.2050701@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.