All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4
Date: Tue, 14 Oct 2014 11:01:09 +0100	[thread overview]
Message-ID: <1413280869.10417.14.camel@citrix.com> (raw)
In-Reply-To: <1412925588-27702-1-git-send-email-olaf@aepfle.de>

On Fri, 2014-10-10 at 09:19 +0200, Olaf Hering wrote:
> Use AS_HELP_STRING for proper formating, mention both options take a
> directory, mention the default value, quote the arguments in brackets.
> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>

Acked + applied.

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  m4/systemd.m4 | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/m4/systemd.m4 b/m4/systemd.m4
> index 760bbad..629d202 100644
> --- a/m4/systemd.m4
> +++ b/m4/systemd.m4
> @@ -18,12 +18,16 @@
>  
>  dnl Some optional path options
>  AC_DEFUN([AX_SYSTEMD_OPTIONS], [
> -	AC_ARG_WITH(systemd, [  --with-systemd          set directory for systemd service files],
> -		SYSTEMD_DIR="$withval", SYSTEMD_DIR="")
> +	AC_ARG_WITH(systemd,
> +		AS_HELP_STRING([--with-systemd=DIR],
> +		[set directory for systemd service files [PREFIX/lib/systemd/system]]),
> +		[SYSTEMD_DIR="$withval"],[SYSTEMD_DIR=""])
>  	AC_SUBST(SYSTEMD_DIR)
>  
> -	AC_ARG_WITH(systemd, [  --with-systemd-modules-load          set directory for systemd modules load files],
> -		SYSTEMD_MODULES_LOAD="$withval", SYSTEMD_MODULES_LOAD="")
> +	AC_ARG_WITH(systemd,
> +		AS_HELP_STRING([--with-systemd-modules-load=DIR],
> +		[set directory for systemd modules load files [PREFIX/lib/modules-load.d/]]),
> +		[SYSTEMD_MODULES_LOAD="$withval"], [SYSTEMD_MODULES_LOAD=""])
>  	AC_SUBST(SYSTEMD_MODULES_LOAD)
>  ])
>  

      reply	other threads:[~2014-10-14 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  7:19 [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4 Olaf Hering
2014-10-14 10:01 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413280869.10417.14.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=olaf@aepfle.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.