* [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4
@ 2014-10-10 7:19 Olaf Hering
2014-10-14 10:01 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2014-10-10 7:19 UTC (permalink / raw)
To: xen-devel
Cc: Olaf Hering, Wei Liu, Ian Campbell, Stefano Stabellini,
Ian Jackson
Use AS_HELP_STRING for proper formating, mention both options take a
directory, mention the default value, quote the arguments in brackets.
Please rerun autogen.sh after applying this patch.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
m4/systemd.m4 | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/m4/systemd.m4 b/m4/systemd.m4
index 760bbad..629d202 100644
--- a/m4/systemd.m4
+++ b/m4/systemd.m4
@@ -18,12 +18,16 @@
dnl Some optional path options
AC_DEFUN([AX_SYSTEMD_OPTIONS], [
- AC_ARG_WITH(systemd, [ --with-systemd set directory for systemd service files],
- SYSTEMD_DIR="$withval", SYSTEMD_DIR="")
+ AC_ARG_WITH(systemd,
+ AS_HELP_STRING([--with-systemd=DIR],
+ [set directory for systemd service files [PREFIX/lib/systemd/system]]),
+ [SYSTEMD_DIR="$withval"],[SYSTEMD_DIR=""])
AC_SUBST(SYSTEMD_DIR)
- AC_ARG_WITH(systemd, [ --with-systemd-modules-load set directory for systemd modules load files],
- SYSTEMD_MODULES_LOAD="$withval", SYSTEMD_MODULES_LOAD="")
+ AC_ARG_WITH(systemd,
+ AS_HELP_STRING([--with-systemd-modules-load=DIR],
+ [set directory for systemd modules load files [PREFIX/lib/modules-load.d/]]),
+ [SYSTEMD_MODULES_LOAD="$withval"], [SYSTEMD_MODULES_LOAD=""])
AC_SUBST(SYSTEMD_MODULES_LOAD)
])
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4
2014-10-10 7:19 [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4 Olaf Hering
@ 2014-10-14 10:01 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2014-10-14 10:01 UTC (permalink / raw)
To: Olaf Hering; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini, xen-devel
On Fri, 2014-10-10 at 09:19 +0200, Olaf Hering wrote:
> Use AS_HELP_STRING for proper formating, mention both options take a
> directory, mention the default value, quote the arguments in brackets.
>
> Please rerun autogen.sh after applying this patch.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
Acked + applied.
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> m4/systemd.m4 | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/m4/systemd.m4 b/m4/systemd.m4
> index 760bbad..629d202 100644
> --- a/m4/systemd.m4
> +++ b/m4/systemd.m4
> @@ -18,12 +18,16 @@
>
> dnl Some optional path options
> AC_DEFUN([AX_SYSTEMD_OPTIONS], [
> - AC_ARG_WITH(systemd, [ --with-systemd set directory for systemd service files],
> - SYSTEMD_DIR="$withval", SYSTEMD_DIR="")
> + AC_ARG_WITH(systemd,
> + AS_HELP_STRING([--with-systemd=DIR],
> + [set directory for systemd service files [PREFIX/lib/systemd/system]]),
> + [SYSTEMD_DIR="$withval"],[SYSTEMD_DIR=""])
> AC_SUBST(SYSTEMD_DIR)
>
> - AC_ARG_WITH(systemd, [ --with-systemd-modules-load set directory for systemd modules load files],
> - SYSTEMD_MODULES_LOAD="$withval", SYSTEMD_MODULES_LOAD="")
> + AC_ARG_WITH(systemd,
> + AS_HELP_STRING([--with-systemd-modules-load=DIR],
> + [set directory for systemd modules load files [PREFIX/lib/modules-load.d/]]),
> + [SYSTEMD_MODULES_LOAD="$withval"], [SYSTEMD_MODULES_LOAD=""])
> AC_SUBST(SYSTEMD_MODULES_LOAD)
> ])
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-14 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 7:19 [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4 Olaf Hering
2014-10-14 10:01 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.