From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile
Date: Tue, 14 Oct 2014 11:01:29 +0100 [thread overview]
Message-ID: <1413280889.10417.16.camel@citrix.com> (raw)
In-Reply-To: <1412933005-25973-1-git-send-email-olaf@aepfle.de>
On Fri, 2014-10-10 at 11:23 +0200, Olaf Hering wrote:
> The variables should have been removed already in
> 7ed06911dc596d23f21dee209b7f2db294e34b56 ("Remove dead qemu code from
> toplevel Makefile"), but I did not spot it at this time.
> Now it looks like the intention initially was to let the install-tools
> depend on tools/qemu-xen-traditional-dir. But that did not work because
> there was the typo in the variables (TGT vs. TARGET), and
> CONFIG_QEMU_TRAD was not defined anyway.
>
> So remove QEMU_TRAD_DIR_TARGET and QEMU_XEN_DIR_TARGET because they are
> not defined at all.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked + applied.
prev parent reply other threads:[~2014-10-14 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 9:23 [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile Olaf Hering
2014-10-14 10:01 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413280889.10417.16.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.