All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile
@ 2014-10-10  9:23 Olaf Hering
  2014-10-14 10:01 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2014-10-10  9:23 UTC (permalink / raw)
  To: xen-devel
  Cc: Olaf Hering, Wei Liu, Ian Campbell, Stefano Stabellini,
	Ian Jackson

The variables should have been removed already in
7ed06911dc596d23f21dee209b7f2db294e34b56 ("Remove dead qemu code from
toplevel Makefile"), but I did not spot it at this time.
Now it looks like the intention initially was to let the install-tools
depend on tools/qemu-xen-traditional-dir. But that did not work because
there was the typo in the variables (TGT vs. TARGET), and
CONFIG_QEMU_TRAD was not defined anyway.

So remove QEMU_TRAD_DIR_TARGET and QEMU_XEN_DIR_TARGET because they are
not defined at all.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 0355b49..f540e07 100644
--- a/Makefile
+++ b/Makefile
@@ -65,11 +65,11 @@ install-xen:
 	$(MAKE) -C xen install
 
 .PHONY: install-tools
-install-tools: $(QEMU_TRAD_DIR_TARGET) $(QEMU_XEN_DIR_TARGET)
+install-tools:
 	$(MAKE) -C tools install
 
 .PHONY: install-stubdom
-install-stubdom: $(QEMU_TRAD_DIR_TARGET) install-tools
+install-stubdom: install-tools
 	$(MAKE) -C stubdom install
 ifeq (x86_64,$(XEN_TARGET_ARCH))
 	XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom install-grub

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile
  2014-10-10  9:23 [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile Olaf Hering
@ 2014-10-14 10:01 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2014-10-14 10:01 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini, xen-devel

On Fri, 2014-10-10 at 11:23 +0200, Olaf Hering wrote:
> The variables should have been removed already in
> 7ed06911dc596d23f21dee209b7f2db294e34b56 ("Remove dead qemu code from
> toplevel Makefile"), but I did not spot it at this time.
> Now it looks like the intention initially was to let the install-tools
> depend on tools/qemu-xen-traditional-dir. But that did not work because
> there was the typo in the variables (TGT vs. TARGET), and
> CONFIG_QEMU_TRAD was not defined anyway.
> 
> So remove QEMU_TRAD_DIR_TARGET and QEMU_XEN_DIR_TARGET because they are
> not defined at all.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked + applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-14 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10  9:23 [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile Olaf Hering
2014-10-14 10:01 ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.