* [PATCH for-xen-4.5] tools/hotplug: update dependency of var-lib-xenstored.mount
@ 2014-10-15 9:41 Olaf Hering
2014-10-20 14:35 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2014-10-15 9:41 UTC (permalink / raw)
To: xen-devel
Cc: Olaf Hering, Wei Liu, Ian Campbell, Stefano Stabellini,
Ian Jackson
After previous change which uses /proc/xen/capabilities as condition the
unit file has now a dependency on proc-xen.mount. Add a Requires= to let
this unit fail if proc-xen.mount fails. Add an After= as ordering hint.
This was noticed with a pvops dom0, in a xenlinux dom0 the proc file is
always present.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
This is finally tested with a 3.17 pvops dom0.
tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
index 64b560f..d5e04db 100644
--- a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
+++ b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
@@ -1,5 +1,7 @@
[Unit]
Description=mount xenstore file system
+Requires=proc-xen.mount
+After=proc-xen.mount
ConditionPathExists=/proc/xen/capabilities
RefuseManualStop=true
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-xen-4.5] tools/hotplug: update dependency of var-lib-xenstored.mount
2014-10-15 9:41 [PATCH for-xen-4.5] tools/hotplug: update dependency of var-lib-xenstored.mount Olaf Hering
@ 2014-10-20 14:35 ` Ian Campbell
2014-10-20 14:51 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2014-10-20 14:35 UTC (permalink / raw)
To: Olaf Hering; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini, xen-devel
On Wed, 2014-10-15 at 11:41 +0200, Olaf Hering wrote:
> After previous change which uses /proc/xen/capabilities as condition the
> unit file has now a dependency on proc-xen.mount. Add a Requires= to let
> this unit fail if proc-xen.mount fails. Add an After= as ordering hint.
>
> This was noticed with a pvops dom0, in a xenlinux dom0 the proc file is
> always present.
Should this be folded into "tools/hotplug: fix systemd service files for
dom0"?
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>
> This is finally tested with a 3.17 pvops dom0.
>
> tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> index 64b560f..d5e04db 100644
> --- a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> +++ b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> @@ -1,5 +1,7 @@
> [Unit]
> Description=mount xenstore file system
> +Requires=proc-xen.mount
> +After=proc-xen.mount
> ConditionPathExists=/proc/xen/capabilities
> RefuseManualStop=true
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-xen-4.5] tools/hotplug: update dependency of var-lib-xenstored.mount
2014-10-20 14:35 ` Ian Campbell
@ 2014-10-20 14:51 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2014-10-20 14:51 UTC (permalink / raw)
To: Ian Campbell; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini, xen-devel
On Mon, Oct 20, Ian Campbell wrote:
> On Wed, 2014-10-15 at 11:41 +0200, Olaf Hering wrote:
> > After previous change which uses /proc/xen/capabilities as condition the
> > unit file has now a dependency on proc-xen.mount. Add a Requires= to let
> > this unit fail if proc-xen.mount fails. Add an After= as ordering hint.
> >
> > This was noticed with a pvops dom0, in a xenlinux dom0 the proc file is
> > always present.
>
> Should this be folded into "tools/hotplug: fix systemd service files for
> dom0"?
Yes, if thats possible.
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-20 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-15 9:41 [PATCH for-xen-4.5] tools/hotplug: update dependency of var-lib-xenstored.mount Olaf Hering
2014-10-20 14:35 ` Ian Campbell
2014-10-20 14:51 ` Olaf Hering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.