From: Ian Campbell <Ian.Campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Mark Pryor <tlviewer@yahoo.com>,
"mcgrof@do-not-panic.com" <mcgrof@do-not-panic.com>,
Wei Liu <wei.liu2@citrix.com>,
"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH RFC 2/3] systemd: add xen-init-dom0 service
Date: Tue, 21 Oct 2014 09:49:52 +0100 [thread overview]
Message-ID: <1413881392.29506.17.camel@citrix.com> (raw)
In-Reply-To: <20141021072744.GA10846@aepfle.de>
On Tue, 2014-10-21 at 09:27 +0200, Olaf Hering wrote:
> On Mon, Oct 20, Wei Liu wrote:
>
> > diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in
> > index 013e69e..e3bf837 100644
> > --- a/tools/hotplug/Linux/systemd/xenstored.service.in
> > +++ b/tools/hotplug/Linux/systemd/xenstored.service.in
> > @@ -17,8 +17,6 @@ ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> > ExecStartPre=-/bin/rm -f @XEN_LIB_STORED@/tdb*
> > ExecStartPre=/bin/mkdir -p @XEN_RUN_DIR@
> > ExecStart=/bin/sh -c "exec $XENSTORED --no-fork $XENSTORED_ARGS"
> > -ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/name" "Domain-0"
> > -ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/domid" 0
>
> This should have been in ae931f568fe9e91179f3ff3aab199a84d39a626b
> ("libxl: introduce helper to initialise Dom0").
Since that commit didn't adjust the systemd integration I don't think
that's right. I'm expecting Wei will include it in the eventual patch
set to switch systemd over to the new helper.
>
>
> Acked-by: Olaf Hering <olaf@aepfle.de>
>
>
> Olaf
next prev parent reply other threads:[~2014-10-21 8:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 15:01 [PATCH RFC 0/3] tools: systemd patches Wei Liu
2014-10-20 15:01 ` [PATCH RFC 1/3] systemd: fix clean target in Makefile Wei Liu
2014-10-22 11:12 ` Ian Campbell
2014-10-20 15:01 ` [PATCH RFC 2/3] systemd: add xen-init-dom0 service Wei Liu
2014-10-20 15:24 ` Olaf Hering
2014-10-20 15:40 ` Wei Liu
2014-10-21 8:24 ` Olaf Hering
2014-10-21 9:20 ` Wei Liu
2014-10-21 17:06 ` Mark Pryor
2014-10-22 11:58 ` Wei Liu
2014-10-20 18:53 ` Mark Pryor
2014-10-20 20:27 ` Wei Liu
2014-10-20 20:49 ` Mark Pryor
2014-10-20 21:00 ` Wei Liu
2014-10-21 7:27 ` Olaf Hering
2014-10-21 8:49 ` Ian Campbell [this message]
2014-10-21 9:18 ` Wei Liu
2014-10-20 15:01 ` [PATCH RFC 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
2014-10-22 11:14 ` Ian Campbell
2014-10-22 11:51 ` Olaf Hering
2014-10-22 12:02 ` Wei Liu
2014-10-22 12:11 ` Andrew Cooper
2014-10-22 12:18 ` Olaf Hering
2014-10-22 12:20 ` Wei Liu
2014-10-22 20:26 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413881392.29506.17.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mcgrof@do-not-panic.com \
--cc=olaf@aepfle.de \
--cc=tlviewer@yahoo.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.