All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Olaf Hering <olaf@aepfle.de>
Cc: tlviewer@yahoo.com, xen-devel@lists.xen.org,
	ian.jackson@eu.citrix.com, Ian Campbell <Ian.Campbell@citrix.com>,
	mcgrof@do-not-panic.com
Subject: Re: [PATCH RFC 3/3] systemd: xendomains now depends on xen-init-dom0
Date: Wed, 22 Oct 2014 13:11:44 +0100	[thread overview]
Message-ID: <54479F00.9010702@citrix.com> (raw)
In-Reply-To: <20141022120259.GB5087@zion.uk.xensource.com>

On 22/10/14 13:02, Wei Liu wrote:
> On Wed, Oct 22, 2014 at 01:51:55PM +0200, Olaf Hering wrote:
>> On Wed, Oct 22, Ian Campbell wrote:
>>
>>> On Mon, 2014-10-20 at 16:01 +0100, Wei Liu wrote:
>>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>>> This patch seems to be correct.
>>>
>>> But, should nothing else depend on this? There doesn't seem to be an
>>> umbrella "all the stuff needed for xen" module. Maybe one isn't needed?
> I once thought about this but wasn't quite sure. Given that I was quite
> new to systemd and we were approaching freeze I focused on fixing this
> one bug only. But since you asked, I think a xencommons service is
> sensible.
>
>> Nice that you ask. I was already thinking of a xencommons.service which
>> just depends on everything required. Its certainly possible to enable
>> each manually. This is what I have in my INSTALL file:
>>
> Is this suitable for 4.5? Do you can to take over my systemd patch
> series and work on it for 4.5? I'm fine with that.
>
> Wei.

This systemd support is brand new for 4.5, and it would be lovely to get
it working properly right from the start.

>From a release perspective, the risk is that systemd support will be
better/worse given specific patches, but there is no possibility of
regressions compared to 4.4

~Andrew

  reply	other threads:[~2014-10-22 12:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 15:01 [PATCH RFC 0/3] tools: systemd patches Wei Liu
2014-10-20 15:01 ` [PATCH RFC 1/3] systemd: fix clean target in Makefile Wei Liu
2014-10-22 11:12   ` Ian Campbell
2014-10-20 15:01 ` [PATCH RFC 2/3] systemd: add xen-init-dom0 service Wei Liu
2014-10-20 15:24   ` Olaf Hering
2014-10-20 15:40     ` Wei Liu
2014-10-21  8:24       ` Olaf Hering
2014-10-21  9:20         ` Wei Liu
2014-10-21 17:06           ` Mark Pryor
2014-10-22 11:58             ` Wei Liu
2014-10-20 18:53   ` Mark Pryor
2014-10-20 20:27     ` Wei Liu
2014-10-20 20:49       ` Mark Pryor
2014-10-20 21:00         ` Wei Liu
2014-10-21  7:27       ` Olaf Hering
2014-10-21  8:49         ` Ian Campbell
2014-10-21  9:18           ` Wei Liu
2014-10-20 15:01 ` [PATCH RFC 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
2014-10-22 11:14   ` Ian Campbell
2014-10-22 11:51     ` Olaf Hering
2014-10-22 12:02       ` Wei Liu
2014-10-22 12:11         ` Andrew Cooper [this message]
2014-10-22 12:18         ` Olaf Hering
2014-10-22 12:20           ` Wei Liu
2014-10-22 20:26             ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54479F00.9010702@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=mcgrof@do-not-panic.com \
    --cc=olaf@aepfle.de \
    --cc=tlviewer@yahoo.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.