From: Ian Campbell <Ian.Campbell@citrix.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Anthony Perard <anthony.perard@citrix.com>,
xen-devel@lists.xen.org, netwiz@crc.id.au,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] pvgrub: ignore NUL
Date: Mon, 10 Nov 2014 12:21:17 +0000 [thread overview]
Message-ID: <1415622077.25176.1.camel@citrix.com> (raw)
In-Reply-To: <20141106113923.GA3182@type.bordeaux.inria.fr>
On Thu, 2014-11-06 at 12:39 +0100, Samuel Thibault wrote:
> Stefano Stabellini, le Thu 06 Nov 2014 10:41:28 +0000, a écrit :
> > When using pvgrub in graphical mode with vnc, the grub timeout doesn't
> > work: the countdown doesn't even start. With a serial terminal the
> > problem doesn't occur and the countdown works as expected.
> >
> > It turns out that the problem is that when using a graphical terminal,
> > checkkey () returns 0 instead of -1 when there is no activity on the
> > mouse or keyboard. As a consequence grub thinks that the user typed
> > something and interrupts the count down.
> >
> > To fix the issue simply ignore keystrokes returning 0, that is the NUL
> > character anyway. Add a patch to grub.patches to do that.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Tested-by: Steven Haigh <netwiz@crc.id.au>
>
> Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
I think the conclusion of the subthread was a release ack so applied,
thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-11-10 12:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 15:17 vnc=1 / pvgrub / close fb: backend at /local/domain/0/backend/vfb/xx/0 Steven Haigh
2014-10-21 21:24 ` Steven Haigh
2014-10-22 9:00 ` Ian Campbell
2014-10-22 9:59 ` Samuel Thibault
2014-10-22 10:10 ` Steven Haigh
2014-10-22 10:19 ` Samuel Thibault
2014-10-22 10:31 ` Ian Campbell
2014-10-22 10:45 ` Steven Haigh
2014-10-22 10:40 ` Ian Campbell
2014-10-22 11:57 ` Stefano Stabellini
2014-10-22 12:05 ` Ian Campbell
2014-10-22 12:13 ` Stefano Stabellini
2014-10-22 15:23 ` Steven Haigh
2014-10-22 15:40 ` Ian Campbell
2014-10-22 15:53 ` Steven Haigh
2014-10-23 8:21 ` Ian Campbell
2014-11-05 17:49 ` Stefano Stabellini
2014-11-06 9:49 ` Steven Haigh
2014-11-06 10:34 ` Stefano Stabellini
2014-11-06 11:05 ` Steven Haigh
2014-11-06 10:41 ` [PATCH] pvgrub: ignore NUL Stefano Stabellini
2014-11-06 11:39 ` Samuel Thibault
2014-11-06 15:43 ` Stefano Stabellini
2014-11-06 19:36 ` Konrad Rzeszutek Wilk
2014-11-06 23:13 ` Samuel Thibault
2014-11-10 12:20 ` Ian Campbell
2014-11-10 12:21 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415622077.25176.1.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=netwiz@crc.id.au \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.