Re: vnc=1 / pvgrub / close fb: backend at /local/domain/0/backend/vfb/xx/0

[Steven Haigh <netwiz@crc.id.au>]

[-- Attachment #1.1: Type: text/plain, Size: 2808 bytes --]

Hi Stefano,

It seems that this patch fixes the grub issue for me. I no longer get
the infinite wait at the grub prompt.

On 6/11/2014 4:49 AM, Stefano Stabellini wrote:
> Hello Steven,
> I have found some time to debug this myself.
> I couldn't reproduce the booting issue that you reported: in my case
> after seeing the grub boot menu I can successfully boot the kernel
> without problems.
> 
> However I can reproduce the timeout issue that you are seeing: the
> timeout doesn't work properly in graphics mode.
> 
> The reason is that the with a graphics terminal you checkkey () return 0
> even when pressing no keys, resulting in wrong behaviour in run_menu. 
> 
> Does the following patch (also attached) fixes your issues?
> 
> 
> diff --git a/stubdom/grub.patches/11graphics-keyboard.diff b/stubdom/grub.patches/11graphics-keyboard.diff
> new file mode 100644
> index 0000000..fe17b20
> --- /dev/null
> +++ b/stubdom/grub.patches/11graphics-keyboard.diff
> @@ -0,0 +1,13 @@
> +diff --git a/stage2/stage2.c b/stage2/stage2.c
> +index 9d9fcc3..8353a3b 100644
> +--- a/stage2/stage2.c
> ++++ b/stage2/stage2.c
> +@@ -395,7 +395,7 @@ restart:
> + 	 pressed.  
> + 	 This avoids polling (relevant in the grub-shell and later on
> + 	 in grub if interrupt driven I/O is done).  */
> +-      if (checkkey () >= 0 || grub_timeout < 0)
> ++      if (checkkey () > 0 || grub_timeout < 0)
> + 	{
> + 	  /* Key was pressed, show which entry is selected before GETKEY,
> + 	     since we're comming in here also on GRUB_TIMEOUT == -1 and
> 
> 
> 
> On Thu, 23 Oct 2014, Steven Haigh wrote:
>> On 23/10/2014 2:40 AM, Ian Campbell wrote:
>>> On Thu, 2014-10-23 at 02:23 +1100, Steven Haigh wrote:
>>>
>>>> Output using pv-grub:
>>>
>>> Can you also post the qemu logs please (under /var/log/xen somewhere I
>>> think).
>>
>> I get very little out of this:
>> -rw-r--r--  1 root root    0 Oct 23 02:45 qemu-dm-dev.vm.log
>> -rw-r--r--  1 root root    0 Oct 23 02:44 xen-hotplug.log
>> -rw-r--r--  1 root root   55 Oct 23 02:45 xl-dev.vm.log
>> [root@dom0 xen]# cat xl-dev.vm.log
>> Waiting for domain dev.vm (domid 36) to die [pid 6970]
>>
>> That's it :\
>>
>>>> qemu-system-i38[3956]: segfault at 0 ip           (null) sp
>>>> 00007fffb4573638 error 4
>>>
>>> That might be a smoking gun. Is there a core dump and/or could you try
>>> and run qemu under gdb?
>>
>> Any hints on doing this? I can't say I'm a gdb guru.... I can't find any
>> core dumps anywhere so that's not really helpful...
>>
>> -- 
>> Steven Haigh
>>
>> Email: netwiz@crc.id.au
>> Web: http://www.crc.id.au
>> Phone: (03) 9001 6090 - 0412 935 897
>>

-- 
Steven Haigh

Email: netwiz@crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 834 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel