From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems
Date: Mon, 10 Nov 2014 12:30:19 +0000 [thread overview]
Message-ID: <1415622619.25176.6.camel@citrix.com> (raw)
In-Reply-To: <1415198630-29937-5-git-send-email-ian.jackson@eu.citrix.com>
On Wed, 2014-11-05 at 14:43 +0000, Ian Jackson wrote:
> +If it is not feasible to conform fully to the style while patching old
> +code, without doing substantial style reengineering first, we may
> +accept patches which contain nonconformant elements, provided that
> +they don't make the coding style problem worse overall.
I'd perhaps be a little more explicit and say that the exceptional code
should conform to the (probably implicit) prevailing style in the area
so far as that is possible.
Ian.
next prev parent reply other threads:[~2014-11-10 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 14:43 [RFC PATCH 0/4] libxl: CODING_STYLE improvements Ian Jackson
2014-11-05 14:43 ` [PATCH 1/4] libxl: CODING_STYLE: Much new material Ian Jackson
2014-11-07 12:01 ` Wei Liu
2014-11-10 12:27 ` Ian Campbell
2014-11-14 18:43 ` Ian Jackson
2015-07-28 10:25 ` Ian Campbell
2014-11-05 14:43 ` [PATCH 2/4] libxl: CODING_STYLE: Deprecate `error' for out blocks Ian Jackson
2014-11-05 14:43 ` [PATCH 3/4] libxl: CODING_STYLE: Mention function out parameters Ian Jackson
2014-11-05 14:43 ` [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems Ian Jackson
2014-11-10 12:30 ` Ian Campbell [this message]
2014-11-14 18:45 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2014-11-14 18:52 [PATCH for-4.5 v2 0/4] libxl: CODING_STYLE Ian Jackson
2014-11-14 18:52 ` [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415622619.25176.6.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.