From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/4] libxl: CODING_STYLE: Much new material
Date: Tue, 28 Jul 2015 11:25:13 +0100 [thread overview]
Message-ID: <1438079113.11600.113.camel@citrix.com> (raw)
In-Reply-To: <1415198630-29937-2-git-send-email-ian.jackson@eu.citrix.com>
On Wed, 2014-11-05 at 14:43 +0000, Ian Jackson wrote:
Sorry to be a bit late to the game, do I win a prize? ;-)
[...]
> + Usually, don't use: Instead, use (see libxl_internal.h):
> + libxl__log[v] LOG, LOGE, LOGEV
> + libxl__sprintf GCSPRINTF
> + libxl__*alloc et al. GCNEW, GCNEW_ARRAY, GCREALLOC_ARRAY
> + malloc et al. GCNEW, GCNEW_ARRAY, GCREALLOC_ARRAY with NOGC
This last one isn't possible, because those macros do not take an explicit
gc (they assume gc in the calling context) so you can't pass them NOGC.
Ian.
next prev parent reply other threads:[~2015-07-28 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 14:43 [RFC PATCH 0/4] libxl: CODING_STYLE improvements Ian Jackson
2014-11-05 14:43 ` [PATCH 1/4] libxl: CODING_STYLE: Much new material Ian Jackson
2014-11-07 12:01 ` Wei Liu
2014-11-10 12:27 ` Ian Campbell
2014-11-14 18:43 ` Ian Jackson
2015-07-28 10:25 ` Ian Campbell [this message]
2014-11-05 14:43 ` [PATCH 2/4] libxl: CODING_STYLE: Deprecate `error' for out blocks Ian Jackson
2014-11-05 14:43 ` [PATCH 3/4] libxl: CODING_STYLE: Mention function out parameters Ian Jackson
2014-11-05 14:43 ` [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems Ian Jackson
2014-11-10 12:30 ` Ian Campbell
2014-11-14 18:45 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2014-11-14 18:52 [PATCH for-4.5 v2 0/4] libxl: CODING_STYLE Ian Jackson
2014-11-14 18:52 ` [PATCH 1/4] libxl: CODING_STYLE: Much new material Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438079113.11600.113.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.