From: Joe Perches <joe@perches.com>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: Richard Weinberger <richard@nod.at>,
dedekind1@gmail.com, linux-mtd@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities
Date: Tue, 11 Nov 2014 00:34:46 -0800 [thread overview]
Message-ID: <1415694886.16070.3.camel@perches.com> (raw)
In-Reply-To: <5461C7C6.6060604@codeaurora.org>
On Tue, 2014-11-11 at 10:24 +0200, Tanya Brokhman wrote:
> On 11/10/2014 7:57 PM, Joe Perches wrote:
> > On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote:
> >> Am 03.11.2014 um 14:58 schrieb Tanya Brokhman:
> >>> If there is more then one UBI device mounted, there is no way to
> >>> distinguish between messages from different UBI devices.
> >>> Add device number to all ubi layer message types.
> >
> > Adding "error" and "warning" to the message logs is
> > duplicative to the KERN_<LEVEL> logging information.
> >
> >>> Changes from V5:
> >>> - Added ptr verification @ ubi_err/ubi_msg/ubi_warn
> >>> Removed extra printing of ubi number
> >>> Removed new messages.
> >
> > Did you all ever look at what I posted?
>
> I did. Its not my place to re-post your change in my patch. I personally
> prefer it the way I've done it but it's just a matter of opinion and
> personal preference.
Don't forget object code size.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: dedekind1@gmail.com, Richard Weinberger <richard@nod.at>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities
Date: Tue, 11 Nov 2014 00:34:46 -0800 [thread overview]
Message-ID: <1415694886.16070.3.camel@perches.com> (raw)
In-Reply-To: <5461C7C6.6060604@codeaurora.org>
On Tue, 2014-11-11 at 10:24 +0200, Tanya Brokhman wrote:
> On 11/10/2014 7:57 PM, Joe Perches wrote:
> > On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote:
> >> Am 03.11.2014 um 14:58 schrieb Tanya Brokhman:
> >>> If there is more then one UBI device mounted, there is no way to
> >>> distinguish between messages from different UBI devices.
> >>> Add device number to all ubi layer message types.
> >
> > Adding "error" and "warning" to the message logs is
> > duplicative to the KERN_<LEVEL> logging information.
> >
> >>> Changes from V5:
> >>> - Added ptr verification @ ubi_err/ubi_msg/ubi_warn
> >>> Removed extra printing of ubi number
> >>> Removed new messages.
> >
> > Did you all ever look at what I posted?
>
> I did. Its not my place to re-post your change in my patch. I personally
> prefer it the way I've done it but it's just a matter of opinion and
> personal preference.
Don't forget object code size.
next prev parent reply other threads:[~2014-11-11 8:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 13:58 [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities Tanya Brokhman
2014-11-03 13:58 ` Tanya Brokhman
2014-11-03 13:58 ` Tanya Brokhman
2014-11-05 15:35 ` Artem Bityutskiy
2014-11-05 15:35 ` Artem Bityutskiy
2014-11-07 10:08 ` hujianyang
2014-11-07 10:08 ` hujianyang
2014-11-07 10:08 ` hujianyang
2014-11-07 12:32 ` Tanya Brokhman
2014-11-10 17:37 ` Richard Weinberger
2014-11-10 17:37 ` Richard Weinberger
2014-11-10 17:57 ` Joe Perches
2014-11-10 17:57 ` Joe Perches
2014-11-11 8:24 ` Tanya Brokhman
2014-11-11 8:24 ` Tanya Brokhman
2014-11-11 8:34 ` Joe Perches [this message]
2014-11-11 8:34 ` Joe Perches
2014-11-11 8:56 ` Richard Weinberger
2014-11-11 8:56 ` Richard Weinberger
2014-11-11 9:53 ` Tanya Brokhman
2014-11-11 11:35 ` Artem Bityutskiy
2014-11-11 11:44 ` Artem Bityutskiy
2014-11-11 11:44 ` Artem Bityutskiy
2014-11-11 8:15 ` Richard Weinberger
2014-11-11 8:15 ` Richard Weinberger
2014-11-11 12:03 ` Artem Bityutskiy
2014-11-11 12:03 ` Artem Bityutskiy
2014-11-11 12:25 ` Richard Weinberger
2014-11-11 12:25 ` Richard Weinberger
2014-11-11 13:27 ` Artem Bityutskiy
2014-11-11 13:27 ` Artem Bityutskiy
2014-11-11 19:49 ` Richard Weinberger
2014-11-11 19:49 ` Richard Weinberger
2014-11-12 12:32 ` Artem Bityutskiy
2014-11-12 12:32 ` Artem Bityutskiy
2014-12-29 3:14 ` hujianyang
2014-12-29 3:14 ` hujianyang
2014-12-29 3:14 ` hujianyang
2014-12-29 14:15 ` Tanya Brokhman
2014-12-29 14:15 ` Tanya Brokhman
2014-12-30 1:27 ` hujianyang
2014-12-30 1:27 ` hujianyang
2014-12-30 1:27 ` hujianyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415694886.16070.3.camel@perches.com \
--to=joe@perches.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.