[TestDay] VMX test report for Xen 4.5.0-rc1

[TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

Hi All,

This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.

Test environment:
Xen: Xen 4.5-rc1 
Dom0: Linux kernel 3.17.0
Hardware: Intel IVT-EX, Haswell-EP, BDW Client, HSW-EX, IVT-EX, HSW-UP

New bugs(9):
1. with "xen_platform_pci=0" option, the guest with VT-d device fails to boot up
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1893
2. Failed to hotplug a VT-d device with XEN4.5-RC1
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
3. Fail to hot add multi devices to guest
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1895
4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896
5. Dom0 failed to resume from S3 power state
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1897
6. Networking is unavailable after save&restore Windows guest
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
7. Error msg occurred after attaching multi SR-IOV VF device to running guest
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1899
8. "xl vcpu-set " will report error when adding vcpus number
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1900
9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901

1 old legacy bug(1):
1. Guest hang after resume from S3
  http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1828


Best Regards,
Robert

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Jan Beulich]

>>> On 12.11.14 at 07:58, <robert.hu@intel.com> wrote:
> 2. Failed to hotplug a VT-d device with XEN4.5-RC1
>   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894 

First of all I'm not sure it is really useful to use the old, discontinued
bugzilla to report bugs. I think it would be much easier if you reported
them directly (and individually) to the mailing list, with or without
triggering the creation of bugs in the new tracking system.

As to the specific bug above - nothing is being said on whether a
driver was still attached to the device at the time it was being
hot-unplugged; if there was, I'm not sure what the expected
behavior would be (i.e. on real hardware).

> 3. Fail to hot add multi devices to guest
>   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1895 

The description in contradicting itself - title and parts of it say
the operation failed, but "Bug detailed description" says "Checking
inside guest VM, the VT-D device is attached to guest VM actually,
and works fine."

> 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
>   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896 

I think we were told the other day that pass-through of PFs is
not being supported by Intel. What's the purpose of reporting
bugs there?

> 7. Error msg occurred after attaching multi SR-IOV VF device to running guest
>   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1899 

This reads (except for the title) the same as 1895. Am I overlooking
something here?

Jan

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Fabio Fantoni]

Il 12/11/2014 07:58, Hu, Robert ha scritto:
> Hi All,
>
> This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
>
> Test environment:
> Xen: Xen 4.5-rc1
> Dom0: Linux kernel 3.17.0
> Hardware: Intel IVT-EX, Haswell-EP, BDW Client, HSW-EX, IVT-EX, HSW-UP
>
> New bugs(9):
> 1. with "xen_platform_pci=0" option, the guest with VT-d device fails to boot up
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1893

Have you tried with recent domU's kernel that contain this commit?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=51c71a3bbaca868043cc45b3ad3786dd48a90235
If I remember good there is a critical boot problem with 
"xen_platform_pci=0" and without it.

> 2. Failed to hotplug a VT-d device with XEN4.5-RC1
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> 3. Fail to hot add multi devices to guest
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1895
> 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896
> 5. Dom0 failed to resume from S3 power state
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1897
> 6. Networking is unavailable after save&restore Windows guest
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898

Should be the same problem I reported 1 year ago or more and still 
present, the workaround is use fixed mac address in domUs xl cfg :(
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html

> 7. Error msg occurred after attaching multi SR-IOV VF device to running guest
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1899
> 8. "xl vcpu-set " will report error when adding vcpus number
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1900
> 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901
>
> 1 old legacy bug(1):
> 1. Guest hang after resume from S3
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1828
>
>
> Best Regards,
> Robert
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

Best Regards,
Robert Ho

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Wednesday, November 12, 2014 5:49 PM
> To: Hu, Robert
> Cc: xen-devel@lists.xen.org; Konrad Rzeszutek Wilk
> Subject: Re: [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> >>> On 12.11.14 at 07:58, <robert.hu@intel.com> wrote:
> > 2. Failed to hotplug a VT-d device with XEN4.5-RC1
> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> 
> First of all I'm not sure it is really useful to use the old, discontinued
> bugzilla to report bugs. I think it would be much easier if you reported
> them directly (and individually) to the mailing list, with or without
> triggering the creation of bugs in the new tracking system.
> 
First of all, thanks for your attention.
I think it shall be stored somewhere and be tracked, rather than one by one mail thread. To follow your suggestion, I would next time in addition send each bug per mail, with descriptions contained.
> As to the specific bug above - nothing is being said on whether a
> driver was still attached to the device at the time it was being
> hot-unplugged; if there was, I'm not sure what the expected
> behavior would be (i.e. on real hardware).
As http://wiki.xen.org/wiki/Xen_4.5_RC1_test_instructions says, we as QA engineer "Report any bugs / missing functionality / unexpected results. " Of course, we would help provide as much debug information as we can. 
The expected behavior shall be no error output observed here.
> 
> > 3. Fail to hot add multi devices to guest
> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1895
> 
> The description in contradicting itself - title and parts of it say
> the operation failed, but "Bug detailed description" says "Checking
> inside guest VM, the VT-D device is attached to guest VM actually,
> and works fine."
Yes, it looks ambiguous. Shall have refined the description title more precisely.
> 
> > 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896
> 
> I think we were told the other day that pass-through of PFs is
> not being supported by Intel. What's the purpose of reporting
> bugs there?
This bug was filed before the certainness about PF issue, so this one still follow previous perception. I shall have redefined this bug. Sorry for confusing you. You can ignore this bug itself.
But there is still another issue incurred if we follow the new perception, i.e. xl tool stack should forbid user to assign PF or if you decide to allow user doing so, some further supporting work shall be done.
> 
> > 7. Error msg occurred after attaching multi SR-IOV VF device to running guest
> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1899
> 
> This reads (except for the title) the same as 1895. Am I overlooking
> something here?
The 2 are very similar, this bug is of VF assignment, 1895 refers to similar operation on PFs (only vt-d device, no SR-IOV VFs involved).
>From perspective of QA bug reporting, we encourage tester to report bug as specific/concrete as possible; such situation is allowed that 2 (or more) bugs are finally found same root cause after developer looking into; but it is out of reporter's scope to assert this.
> 
> Jan

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Jan Beulich]

>>> On 12.11.14 at 11:53, <robert.hu@intel.com> wrote:
>> From: Jan Beulich [mailto:JBeulich@suse.com]
>> >>> On 12.11.14 at 07:58, <robert.hu@intel.com> wrote:
>> > 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
>> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896 
>> 
>> I think we were told the other day that pass-through of PFs is
>> not being supported by Intel. What's the purpose of reporting
>> bugs there?
> This bug was filed before the certainness about PF issue, so this one still 
> follow previous perception. I shall have redefined this bug. Sorry for 
> confusing you. You can ignore this bug itself.
> But there is still another issue incurred if we follow the new perception, 
> i.e. xl tool stack should forbid user to assign PF or if you decide to allow 
> user doing so, some further supporting work shall be done.

Why would the tool stack want to enforce such an Intel(-only?)
policy?

Jan

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Wei Liu]

On Wed, Nov 12, 2014 at 06:58:49AM +0000, Hu, Robert wrote:
> Hi All,
> 
> This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> 

> 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
>   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901

See <1415790358-16787-1-git-send-email-wei.liu2@citrix.com>

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Boris Ostrovsky]

On 11/12/2014 01:58 AM, Hu, Robert wrote:
> 2. Failed to hotplug a VT-d device with XEN4.5-RC1
>    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894


This should be addressed by these two:
http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00875.html
http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00874.html

-boris

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Ian Campbell]

On Wed, 2014-11-12 at 10:53 +0000, Hu, Robert wrote:
> I think it shall be stored somewhere and be tracked, rather than one
> by one mail thread. To follow your suggestion, I would next time in
> addition send each bug per mail, with descriptions contained.

If you send each bug as a separate email to xen-devel then if necessary
they can be tracked via http://bugs.xenproject.org/xen/

Ian.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Konrad Rzeszutek Wilk]

On Wed, Nov 12, 2014 at 06:58:49AM +0000, Hu, Robert wrote:
> Hi All,
> 
> This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.

Yeey! Thank you for doing those tests.
> 
> Test environment:
> Xen: Xen 4.5-rc1 
> Dom0: Linux kernel 3.17.0
> Hardware: Intel IVT-EX, Haswell-EP, BDW Client, HSW-EX, IVT-EX, HSW-UP
> 
> New bugs(9):

> 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
>   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896

Please post the bug as an email on xen-devel so we can start the
discussion here.


> 5. Dom0 failed to resume from S3 power state

Interstingly enough it works for me on my AMD box. I will shortly try
it out with the Intel laptop (X230) (been using Xen 4.4 + 3.17.0).

Please post the bug as an email on xen-devel so we can start the
discussion here.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Konrad Rzeszutek Wilk]

On Wed, Nov 12, 2014 at 12:06:20PM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 12, 2014 at 06:58:49AM +0000, Hu, Robert wrote:
> > Hi All,
> > 
> > This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> 
> Yeey! Thank you for doing those tests.
> > 
> > Test environment:
> > Xen: Xen 4.5-rc1 
> > Dom0: Linux kernel 3.17.0
> > Hardware: Intel IVT-EX, Haswell-EP, BDW Client, HSW-EX, IVT-EX, HSW-UP
> > 
> > New bugs(9):
> 
> > 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896
> 
> Please post the bug as an email on xen-devel so we can start the
> discussion here.
> 
> 
> > 5. Dom0 failed to resume from S3 power state
> 
> Interstingly enough it works for me on my AMD box. I will shortly try
> it out with the Intel laptop (X230) (been using Xen 4.4 + 3.17.0).

I put it on laptop (Lenovo X230) and used 'pm-suspend' and as well just
closing the lid. In both cases it worked.

Does that work for you as well?

Thanks.
> 
> Please post the bug as an email on xen-devel so we can start the
> discussion here.
> 

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: Wednesday, November 12, 2014 7:07 PM
> To: Hu, Robert
> Cc: xen-devel@lists.xen.org; JBeulich@suse.com; wei.liu2@citrix.com
> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> On Wed, Nov 12, 2014 at 06:58:49AM +0000, Hu, Robert wrote:
> > Hi All,
> >
> > This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> >
> 
> > 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
> >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901
> 
> See <1415790358-16787-1-git-send-email-wei.liu2@citrix.com>
Thanks for this info. However, what does this link refers to? It is read as 'mailto' link by my mail client. anything missing?

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: Fabio Fantoni [mailto:fabio.fantoni@m2r.biz]
> Sent: Wednesday, November 12, 2014 5:59 PM
> To: Hu, Robert; xen-devel@lists.xen.org
> Cc: JBeulich@suse.com
> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> Il 12/11/2014 07:58, Hu, Robert ha scritto:
> > Hi All,
> >
> > This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> >
> > Test environment:
> > Xen: Xen 4.5-rc1
> > Dom0: Linux kernel 3.17.0
> > Hardware: Intel IVT-EX, Haswell-EP, BDW Client, HSW-EX, IVT-EX, HSW-UP
> >
> > New bugs(9):
> > 1. with "xen_platform_pci=0" option, the guest with VT-d device fails to boot
> up
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1893
> 
> Have you tried with recent domU's kernel that contain this commit?
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=51c71a
> 3bbaca868043cc45b3ad3786dd48a90235
No, we test guest OS with their native kernels.
> If I remember good there is a critical boot problem with
> "xen_platform_pci=0" and without it.
In this test case scenario, guest boots up fine.
> 
> > 2. Failed to hotplug a VT-d device with XEN4.5-RC1
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> > 3. Fail to hot add multi devices to guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1895
> > 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896
> > 5. Dom0 failed to resume from S3 power state
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1897
> > 6. Networking is unavailable after save&restore Windows guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> 
> Should be the same problem I reported 1 year ago or more and still
> present, the workaround is use fixed mac address in domUs xl cfg :(
> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
> 
Thanks a lot for this info!
> > 7. Error msg occurred after attaching multi SR-IOV VF device to running guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1899
> > 8. "xl vcpu-set " will report error when adding vcpus number
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1900
> > 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901
> >
> > 1 old legacy bug(1):
> > 1. Guest hang after resume from S3
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1828
> >
> >
> > Best Regards,
> > Robert
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Ian Campbell]

On Thu, 2014-11-13 at 01:22 +0000, Hu, Robert wrote:
> > -----Original Message-----
> > From: Wei Liu [mailto:wei.liu2@citrix.com]
> > Sent: Wednesday, November 12, 2014 7:07 PM
> > To: Hu, Robert
> > Cc: xen-devel@lists.xen.org; JBeulich@suse.com; wei.liu2@citrix.com
> > Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> > 
> > On Wed, Nov 12, 2014 at 06:58:49AM +0000, Hu, Robert wrote:
> > > Hi All,
> > >
> > > This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> > >
> > 
> > > 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
> > >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901
> > 
> > See <1415790358-16787-1-git-send-email-wei.liu2@citrix.com>
> Thanks for this info. However, what does this link refers to? It is
> read as 'mailto' link by my mail client. anything missing?

It is a message-id (a header from every email which somewhat uniquely
identifies it). Many mailing list archives will let you lookup a message
by this identifier. e.g.

http://mid.gmane.org/<1415790358-16787-1-git-send-email-wei.liu2@citrix.com>
http://marc.info/?i=<1415790358-16787-1-git-send-email-wei.liu2@citrix.com>

Note that the <>'s are part of the message-id itself.

Ian.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Wei Liu]

On Thu, Nov 13, 2014 at 01:22:49AM +0000, Hu, Robert wrote:
> > -----Original Message-----
> > From: Wei Liu [mailto:wei.liu2@citrix.com]
> > Sent: Wednesday, November 12, 2014 7:07 PM
> > To: Hu, Robert
> > Cc: xen-devel@lists.xen.org; JBeulich@suse.com; wei.liu2@citrix.com
> > Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> > 
> > On Wed, Nov 12, 2014 at 06:58:49AM +0000, Hu, Robert wrote:
> > > Hi All,
> > >
> > > This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> > >
> > 
> > > 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
> > >   http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901
> > 
> > See <1415790358-16787-1-git-send-email-wei.liu2@citrix.com>
> Thanks for this info. However, what does this link refers to? It is read as 'mailto' link by my mail client. anything missing?

This is email message id.

https://en.wikipedia.org/wiki/Message-ID

You can use it to locate a particular email.

Wei.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: Fabio Fantoni [mailto:fabio.fantoni@m2r.biz]
> Sent: Wednesday, November 12, 2014 5:59 PM
> To: Hu, Robert; xen-devel@lists.xen.org
> Cc: JBeulich@suse.com
> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> Il 12/11/2014 07:58, Hu, Robert ha scritto:
> > Hi All,
> >
> > This is a bug summary for Xen 4.5-rc1 on Intel Server platforms.
> >
> > Test environment:
> > Xen: Xen 4.5-rc1
> > Dom0: Linux kernel 3.17.0
> > Hardware: Intel IVT-EX, Haswell-EP, BDW Client, HSW-EX, IVT-EX, HSW-UP
> >
> > New bugs(9):
> > 1. with "xen_platform_pci=0" option, the guest with VT-d device fails to boot
> up
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1893
> 
> Have you tried with recent domU's kernel that contain this commit?
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=51c71a
> 3bbaca868043cc45b3ad3786dd48a90235
> If I remember good there is a critical boot problem with
> "xen_platform_pci=0" and without it.
> 
> > 2. Failed to hotplug a VT-d device with XEN4.5-RC1
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> > 3. Fail to hot add multi devices to guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1895
> > 4. Not all PFs are available if assign multi VT-d devices to Wndows guest VM
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1896
> > 5. Dom0 failed to resume from S3 power state
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1897
> > 6. Networking is unavailable after save&restore Windows guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> 
> Should be the same problem I reported 1 year ago or more and still
> present, the workaround is use fixed mac address in domUs xl cfg :(
> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
if we assign vif as following, it works with fix-mac.
	# Network devices
	vif = [ 'type=ioemu, mac=00:15:17:19:2D:35, bridge=xenbr0' ]
if we assign VF to guest as following, it till don't have network working with fix-mac; after save&restore, the networking status shows as "Network cable unplugged", without IP address.
    #SR-IOV VF device BDF
    pci = [ '81:10.1' ]
> 
> > 7. Error msg occurred after attaching multi SR-IOV VF device to running guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1899
> > 8. "xl vcpu-set " will report error when adding vcpus number
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1900
> > 9. "xl psr-cmt-show cache_occupancy $dom_id" will report error
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1901
> >
> > 1 old legacy bug(1):
> > 1. Guest hang after resume from S3
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1828
> >
> >
> > Best Regards,
> > Robert
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Ian Campbell]

I've not seen an individual thread on this one, so replying here.

On Wed, 2014-11-12 at 10:59 +0100, Fabio Fantoni wrote:

> > 6. Networking is unavailable after save&restore Windows guest
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> 
> Should be the same problem I reported 1 year ago or more and still 
> present, the workaround is use fixed mac address in domUs xl cfg :(
> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html

Wei, shouldn't your json migration thing have solved this? (this being
the preservation of a vif's mac addr over migration?)

Robert, all reports of toolstack bugs should include a full set of logs.
See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for general
advice on reporting bugs as well as lists of specific things which
should be included.

Ian.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Wei Liu]

On Fri, Nov 14, 2014 at 09:42:56AM +0000, Ian Campbell wrote:
> I've not seen an individual thread on this one, so replying here.
> 
> On Wed, 2014-11-12 at 10:59 +0100, Fabio Fantoni wrote:
> 
> > > 6. Networking is unavailable after save&restore Windows guest
> > >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> > 
> > Should be the same problem I reported 1 year ago or more and still 
> > present, the workaround is use fixed mac address in domUs xl cfg :(
> > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
> 
> Wei, shouldn't your json migration thing have solved this? (this being
> the preservation of a vif's mac addr over migration?)
> 

I think so.

> Robert, all reports of toolstack bugs should include a full set of logs.
> See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for general
> advice on reporting bugs as well as lists of specific things which
> should be included.
> 

Right, without detailed logs it's hard to tell what's going on.

Wei.

> Ian.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: xen-devel-bounces@lists.xen.org
> [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of Ian Campbell
> Sent: Friday, November 14, 2014 5:43 PM
> To: Fabio Fantoni; Wei Liu
> Cc: Hu, Robert; JBeulich@suse.com; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> I've not seen an individual thread on this one, so replying here.
> 
> On Wed, 2014-11-12 at 10:59 +0100, Fabio Fantoni wrote:
> 
> > > 6. Networking is unavailable after save&restore Windows guest
> > >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> >
> > Should be the same problem I reported 1 year ago or more and still
> > present, the workaround is use fixed mac address in domUs xl cfg :(
> > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
> 
> Wei, shouldn't your json migration thing have solved this? (this being
> the preservation of a vif's mac addr over migration?)
> 
> Robert, all reports of toolstack bugs should include a full set of logs.
> See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for general
> advice on reporting bugs as well as lists of specific things which
> should be included.
Thanks Ian. Will rerun this test case in RC2 testing, and if still there, append the full logs then.
> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Fabio Fantoni]

Il 14/11/2014 11:14, Hu, Robert ha scritto:
>> -----Original Message-----
>> From: xen-devel-bounces@lists.xen.org
>> [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of Ian Campbell
>> Sent: Friday, November 14, 2014 5:43 PM
>> To: Fabio Fantoni; Wei Liu
>> Cc: Hu, Robert; JBeulich@suse.com; xen-devel@lists.xen.org
>> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
>>
>> I've not seen an individual thread on this one, so replying here.
>>
>> On Wed, 2014-11-12 at 10:59 +0100, Fabio Fantoni wrote:
>>
>>>> 6. Networking is unavailable after save&restore Windows guest
>>>>     http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
>>> Should be the same problem I reported 1 year ago or more and still
>>> present, the workaround is use fixed mac address in domUs xl cfg :(
>>> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
>>> http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
>> Wei, shouldn't your json migration thing have solved this? (this being
>> the preservation of a vif's mac addr over migration?)
>>
>> Robert, all reports of toolstack bugs should include a full set of logs.
>> See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for general
>> advice on reporting bugs as well as lists of specific things which
>> should be included.
> Thanks Ian. Will rerun this test case in RC2 testing, and if still there, append the full logs then.

I not tried without fixed mac in latest weeks until now, and the problem 
seems solved.
dom0 xen-unstable from staging git with "x86/hvm: Extend HVM cpuid leaf 
with vcpu id" and "x86/hvm: Add per-vcpu evtchn upcalls" patches, and 
qemu 2.2 from spice git:
https://github.com/Fantu/Xen/commits/rebase/m2r-staging
I tried windows 7 domU with latest winpv drivers from git.
Sorry if I not tried before in recently builds.

>> Ian.
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Wei Liu]

On Fri, Nov 14, 2014 at 10:14:32AM +0000, Hu, Robert wrote:
> 
> > -----Original Message-----
> > From: xen-devel-bounces@lists.xen.org
> > [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of Ian Campbell
> > Sent: Friday, November 14, 2014 5:43 PM
> > To: Fabio Fantoni; Wei Liu
> > Cc: Hu, Robert; JBeulich@suse.com; xen-devel@lists.xen.org
> > Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> > 
> > I've not seen an individual thread on this one, so replying here.
> > 
> > On Wed, 2014-11-12 at 10:59 +0100, Fabio Fantoni wrote:
> > 
> > > > 6. Networking is unavailable after save&restore Windows guest
> > > >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> > >
> > > Should be the same problem I reported 1 year ago or more and still
> > > present, the workaround is use fixed mac address in domUs xl cfg :(
> > > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> > > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
> > 
> > Wei, shouldn't your json migration thing have solved this? (this being
> > the preservation of a vif's mac addr over migration?)
> > 
> > Robert, all reports of toolstack bugs should include a full set of logs.
> > See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for general
> > advice on reporting bugs as well as lists of specific things which
> > should be included.
> Thanks Ian. Will rerun this test case in RC2 testing, and if still there, append the full logs then.

Those patches were applied before RC1, so you can paste those logs now.
;-)

> > 
> > Ian.
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Ian Campbell]

On Fri, 2014-11-14 at 10:14 +0000, Hu, Robert wrote:
> Will rerun this test case in RC2 testing, and if still there, append
> the full logs then.

Thank you.

BTW, I've pointed this need for logs out to multiple of your
predecessors over the years. If you could try and get this information
(e.g. the link to the wiki, the need for logs in the general case) added
to your internal documentation (test plan, onboard docs for new
engineers, etc) that would be awesome.

Ian.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: Ian Campbell [mailto:Ian.Campbell@citrix.com]
> Sent: Friday, November 14, 2014 7:28 PM
> To: Hu, Robert
> Cc: Fabio Fantoni; Wei Liu; JBeulich@suse.com; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> On Fri, 2014-11-14 at 10:14 +0000, Hu, Robert wrote:
> > Will rerun this test case in RC2 testing, and if still there, append
> > the full logs then.
> 
> Thank you.
> 
> BTW, I've pointed this need for logs out to multiple of your
> predecessors over the years. If you could try and get this information
> (e.g. the link to the wiki, the need for logs in the general case) added
> to your internal documentation (test plan, onboard docs for new
> engineers, etc) that would be awesome.
Yes, I'm trying to perfect the procedure in this direction.
> 
> Ian.

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> Sent: Wednesday, November 12, 2014 8:39 PM
> To: Hu, Robert; xen-devel@lists.xen.org
> Cc: JBeulich@suse.com
> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> 
> On 11/12/2014 01:58 AM, Hu, Robert wrote:
> > 2. Failed to hotplug a VT-d device with XEN4.5-RC1
> >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> 
> 
> This should be addressed by these two:
> http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00875.html
> http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00874.html
Tried, these patches works. When will they get in?
> 
> -boris

Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Konrad Rzeszutek Wilk]

On Mon, Nov 24, 2014 at 07:43:49AM +0000, Hu, Robert wrote:
> > -----Original Message-----
> > From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> > Sent: Wednesday, November 12, 2014 8:39 PM
> > To: Hu, Robert; xen-devel@lists.xen.org
> > Cc: JBeulich@suse.com
> > Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> > 
> > 
> > On 11/12/2014 01:58 AM, Hu, Robert wrote:
> > > 2. Failed to hotplug a VT-d device with XEN4.5-RC1
> > >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> > 
> > 
> > This should be addressed by these two:
> > http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00875.html
> > http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00874.html
> Tried, these patches works. When will they get in?

CC-ed Ian's so they are aware of the independent testing done by Intel.

Thank you!
> > 
> > -boris
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Boris Ostrovsky]

On 11/24/2014 09:54 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 24, 2014 at 07:43:49AM +0000, Hu, Robert wrote:
>>> -----Original Message-----
>>> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
>>> Sent: Wednesday, November 12, 2014 8:39 PM
>>> To: Hu, Robert; xen-devel@lists.xen.org
>>> Cc: JBeulich@suse.com
>>> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
>>>
>>>
>>> On 11/12/2014 01:58 AM, Hu, Robert wrote:
>>>> 2. Failed to hotplug a VT-d device with XEN4.5-RC1
>>>>     http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
>>>
>>> This should be addressed by these two:
>>> http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00875.html
>>> http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00874.html
>> Tried, these patches works. When will they get in?


They won't get in in the form that they are now. I will need to rework them.

For this specific problem though I think

http://lists.xen.org/archives/html/xen-devel/2014-11/msg01342.html

should be sufficient. Please give it a try.

Thanks.
-boris


> CC-ed Ian's so they are aware of the independent testing done by Intel.
>
> Thank you!
>>> -boris
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel

Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Robert Hu]

On Fri, 2014-11-14 at 09:42 +0000, Ian Campbell wrote:
> I've not seen an individual thread on this one, so replying here.
> 
> On Wed, 2014-11-12 at 10:59 +0100, Fabio Fantoni wrote:
> 
> > > 6. Networking is unavailable after save&restore Windows guest
> > >    http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1898
> > 
> > Should be the same problem I reported 1 year ago or more and still 
> > present, the workaround is use fixed mac address in domUs xl cfg :(
> > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02459.html
> > http://lists.xen.org/archives/html/xen-devel/2013-04/msg02747.html
> 
> Wei, shouldn't your json migration thing have solved this? (this being
> the preservation of a vif's mac addr over migration?)
> 
> Robert, all reports of toolstack bugs should include a full set of logs.
> See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for general
> advice on reporting bugs as well as lists of specific things which
> should be included.
> 
> Ian.
> 
This issue went away in Xen 4.5 RC2.

Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Hu, Robert]

> -----Original Message-----
> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> Sent: Monday, November 24, 2014 11:13 PM
> To: Konrad Rzeszutek Wilk; Hu, Robert; Ian.Jackson@eu.citrix.com;
> Ian.Campbell@citrix.com
> Cc: xen-devel@lists.xen.org; JBeulich@suse.com
> Subject: Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by
> Intel.Was:Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> 
> On 11/24/2014 09:54 AM, Konrad Rzeszutek Wilk wrote:
> > On Mon, Nov 24, 2014 at 07:43:49AM +0000, Hu, Robert wrote:
> >>> -----Original Message-----
> >>> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> >>> Sent: Wednesday, November 12, 2014 8:39 PM
> >>> To: Hu, Robert; xen-devel@lists.xen.org
> >>> Cc: JBeulich@suse.com
> >>> Subject: Re: [Xen-devel] [TestDay] VMX test report for Xen 4.5.0-rc1
> >>>
> >>>
> >>> On 11/12/2014 01:58 AM, Hu, Robert wrote:
> >>>> 2. Failed to hotplug a VT-d device with XEN4.5-RC1
> >>>>
> http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1894
> >>>
> >>> This should be addressed by these two:
> >>>
> http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00875.html
> >>>
> http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00874.html
> >> Tried, these patches works. When will they get in?
> 
> 
> They won't get in in the form that they are now. I will need to rework them.
> 
> For this specific problem though I think
> 
> http://lists.xen.org/archives/html/xen-devel/2014-11/msg01342.html
We verified this on RC4, it works.
Will your patch get in Xen 4.5 release? Otherwise hotplug vt-d device with a running guest will not work properly.
> 
> should be sufficient. Please give it a try.
> 
> Thanks.
> -boris
> 
> 
> > CC-ed Ian's so they are aware of the independent testing done by Intel.
> >
> > Thank you!
> >>> -boris
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@lists.xen.org
> >> http://lists.xen.org/xen-devel

Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[George Dunlap]

On Thu, Dec 18, 2014 at 4:55 AM, Hu, Robert <robert.hu@intel.com> wrote:
>>
>> For this specific problem though I think
>>
>> http://lists.xen.org/archives/html/xen-devel/2014-11/msg01342.html
> We verified this on RC4, it works.
> Will your patch get in Xen 4.5 release? Otherwise hotplug vt-d device with a running guest will not work properly.

It looks like  IanJ's patch (referenced above) has not been applied.
It's clearly a bug fix, so it probably should be...

 -George

Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Konrad Rzeszutek Wilk]

On Mon, Jan 05, 2015 at 12:48:16PM +0000, George Dunlap wrote:
> On Thu, Dec 18, 2014 at 4:55 AM, Hu, Robert <robert.hu@intel.com> wrote:
> >>
> >> For this specific problem though I think
> >>
> >> http://lists.xen.org/archives/html/xen-devel/2014-11/msg01342.html
> > We verified this on RC4, it works.
> > Will your patch get in Xen 4.5 release? Otherwise hotplug vt-d device with a running guest will not work properly.
> 
> It looks like  IanJ's patch (referenced above) has not been applied.
> It's clearly a bug fix, so it probably should be...

<nods>

Ian, were you waiting on Boris to repost the patches?
> 
>  -George

Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Boris Ostrovsky]

On 01/05/2015 10:27 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Jan 05, 2015 at 12:48:16PM +0000, George Dunlap wrote:
>> On Thu, Dec 18, 2014 at 4:55 AM, Hu, Robert <robert.hu@intel.com> wrote:
>>>> For this specific problem though I think
>>>>
>>>> http://lists.xen.org/archives/html/xen-devel/2014-11/msg01342.html
>>> We verified this on RC4, it works.
>>> Will your patch get in Xen 4.5 release? Otherwise hotplug vt-d device with a running guest will not work properly.
>> It looks like  IanJ's patch (referenced above) has not been applied.
>> It's clearly a bug fix, so it probably should be...
> <nods>
>
> Ian, were you waiting on Boris to repost the patches?

I wasn't planning on resending them. They (or, more likely, it) need to 
be reworked to use async notifications and I haven't done this.

Ian's fix is independent of what I need to do.

-boris

Re: Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1

[Ian Jackson]

Boris Ostrovsky writes ("Re: [Xen-devel] Is: Fixes for xl pci-attach for Xen 4.5 confirmed to fix by Intel.Was:Re: [TestDay] VMX test report for Xen 4.5.0-rc1"):
> On 01/05/2015 10:27 AM, Konrad Rzeszutek Wilk wrote:
> > Ian, were you waiting on Boris to repost the patches?

Yes.

> I wasn't planning on resending them. They (or, more likely, it) need to 
> be reworked to use async notifications and I haven't done this.

Oh.

In the meantime we should apply my fix, but it doesn't have a proper
commit message yet.  I will write one and a release ack request.

Ian.

[PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove

[Ian Jackson]

From: Ian Jackson <iwj@mariner.uk.xensource.com>

do_pci_remove contained this:

    if (type == LIBXL_DOMAIN_TYPE_HVM) {
       [stuff]
    } else if (type != LIBXL_DOMAIN_TYPE_PV)
        abort();
    {

This is bizarre, and not correct.  The effect is that HVM guests end
up running both the proper code and that intended for PV guests.  This
causes (amongst other things) trouble when PCI devices are
hot-unplugged from HVM guests.

This bug was introduced in abfb006f "tools/libxl: explicitly grant
access to needed I/O-memory ranges".

This is clear candidate for Xen 4.5, being a bugfix to an important
feature.

Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Tested-by: Robert Hu <robert.hu@intel.com>
CC: Konrad Wilk <konrad.wilk@oracle.com>
CC: Sander Eikelenboom <linux@eikelenboom.it>
CC: George Dunlap <George.Dunlap@eu.citrix.com>
---
 tools/libxl/libxl_pci.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 316643c..9ae37fa 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1247,9 +1247,9 @@ static int do_pci_remove(libxl__gc *gc, uint32_t domid,
             rc = ERROR_FAIL;
             goto out_fail;
         }
-    } else if (type != LIBXL_DOMAIN_TYPE_PV)
-        abort();
-    {
+    } else {
+        assert(type == LIBXL_DOMAIN_TYPE_PV);
+
         char *sysfs_path = libxl__sprintf(gc, SYSFS_PCI_DEV"/"PCI_BDF"/resource", pcidev->domain,
                                          pcidev->bus, pcidev->dev, pcidev->func);
         FILE *f = fopen(sysfs_path, "r");
-- 
1.7.10.4

Re: [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove

[Ian Campbell]

On Mon, 2015-01-05 at 16:34 +0000, Ian Jackson wrote:
> From: Ian Jackson <iwj@mariner.uk.xensource.com>
> 
> do_pci_remove contained this:
> 
>     if (type == LIBXL_DOMAIN_TYPE_HVM) {
>        [stuff]
>     } else if (type != LIBXL_DOMAIN_TYPE_PV)
>         abort();
>     {
> 
> This is bizarre, and not correct.  The effect is that HVM guests end
> up running both the proper code and that intended for PV guests.  This
> causes (amongst other things) trouble when PCI devices are
> hot-unplugged from HVM guests.
> 
> This bug was introduced in abfb006f "tools/libxl: explicitly grant
> access to needed I/O-memory ranges".
> 
> This is clear candidate for Xen 4.5, being a bugfix to an important
> feature.
> 
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Tested-by: Robert Hu <robert.hu@intel.com>
> CC: Konrad Wilk <konrad.wilk@oracle.com>
> CC: Sander Eikelenboom <linux@eikelenboom.it>
> CC: George Dunlap <George.Dunlap@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Re: [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove

[Konrad Rzeszutek Wilk]

On Mon, Jan 05, 2015 at 04:34:36PM +0000, Ian Jackson wrote:
> From: Ian Jackson <iwj@mariner.uk.xensource.com>
> 
> do_pci_remove contained this:
> 
>     if (type == LIBXL_DOMAIN_TYPE_HVM) {
>        [stuff]
>     } else if (type != LIBXL_DOMAIN_TYPE_PV)
>         abort();
>     {
> 
> This is bizarre, and not correct.  The effect is that HVM guests end
> up running both the proper code and that intended for PV guests.  This
> causes (amongst other things) trouble when PCI devices are
> hot-unplugged from HVM guests.
> 
> This bug was introduced in abfb006f "tools/libxl: explicitly grant
> access to needed I/O-memory ranges".
> 
> This is clear candidate for Xen 4.5, being a bugfix to an important
> feature.
> 
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Tested-by: Robert Hu <robert.hu@intel.com>
> CC: Konrad Wilk <konrad.wilk@oracle.com>

RElease-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> CC: Sander Eikelenboom <linux@eikelenboom.it>
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> ---
>  tools/libxl/libxl_pci.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 316643c..9ae37fa 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1247,9 +1247,9 @@ static int do_pci_remove(libxl__gc *gc, uint32_t domid,
>              rc = ERROR_FAIL;
>              goto out_fail;
>          }
> -    } else if (type != LIBXL_DOMAIN_TYPE_PV)
> -        abort();
> -    {
> +    } else {
> +        assert(type == LIBXL_DOMAIN_TYPE_PV);
> +
>          char *sysfs_path = libxl__sprintf(gc, SYSFS_PCI_DEV"/"PCI_BDF"/resource", pcidev->domain,
>                                           pcidev->bus, pcidev->dev, pcidev->func);
>          FILE *f = fopen(sysfs_path, "r");
> -- 
> 1.7.10.4
> 

Re: [PATCH for-4.5] libxl: Fix if{} nesting in do_pci_remove [and 1 more messages]

[Ian Jackson]

> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> RElease-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Pushed, thanks.

Ian.