All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params
Date: Fri, 21 Nov 2014 07:35:31 +0000	[thread overview]
Message-ID: <1416555331.28873.8.camel@mm-sol.com> (raw)
In-Reply-To: <7e2f4984733343fdb4ea51cf7eb4c339@BY2FFO11FD046.protection.gbl>


On Thu, 2014-11-20 at 08:22 -0800, Sören Brinkmann wrote:
> 
> 
> Also, I hope all my changes here don't break the current behavior. So,
> those 27 driver should still be able to do what they currently do. But I
> hope they could migrated over to use the generic bindings only in the
> longer term, so that these custom properties disappear.
> 
> > > The pinctrl driver just assembles
> > > some data structure that has the information regarding custom properties
> > > and the core handles the rest.
> > 
> > Yup, that is nice. What will be really nice if it also handle custom,
> > "function", "groups" and "pins" properties. Otherwise most of the drivers
> > will not be able to benefit from this.
> 
> Why would you still need those? 

I don't need them :-). The point was that still majority of the drivers
will have custom parsing functions. It would be nice if we could fix
that too. I do understand that using custom "pins", "functions"... is
something which is deprecated, but if core parsing functions allow
passing custom strings for above purposes, in a similar way as your
proposal, it will be easier for those drivers to migrate, I believe.

Regards,
Ivan

WARNING: multiple messages have this Message-ID (diff)
From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params
Date: Fri, 21 Nov 2014 09:35:31 +0200	[thread overview]
Message-ID: <1416555331.28873.8.camel@mm-sol.com> (raw)
In-Reply-To: <7e2f4984733343fdb4ea51cf7eb4c339@BY2FFO11FD046.protection.gbl>


On Thu, 2014-11-20 at 08:22 -0800, S?ren Brinkmann wrote:
> 
> 
> Also, I hope all my changes here don't break the current behavior. So,
> those 27 driver should still be able to do what they currently do. But I
> hope they could migrated over to use the generic bindings only in the
> longer term, so that these custom properties disappear.
> 
> > > The pinctrl driver just assembles
> > > some data structure that has the information regarding custom properties
> > > and the core handles the rest.
> > 
> > Yup, that is nice. What will be really nice if it also handle custom,
> > "function", "groups" and "pins" properties. Otherwise most of the drivers
> > will not be able to benefit from this.
> 
> Why would you still need those? 

I don't need them :-). The point was that still majority of the drivers
will have custom parsing functions. It would be nice if we could fix
that too. I do understand that using custom "pins", "functions"... is
something which is deprecated, but if core parsing functions allow
passing custom strings for above purposes, in a similar way as your
proposal, it will be easier for those drivers to migrate, I believe.

Regards,
Ivan

WARNING: multiple messages have this Message-ID (diff)
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bjorn Andersson <Bjorn.Andersson@sonymobile.com>,
	Michal Simek <michal.simek@xilinx.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Alessandro Rubini <rubini@unipv.it>,
	Heiko Stuebner <heiko@sntech.de>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-rockchip@lists.infradead.org,
	"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params
Date: Fri, 21 Nov 2014 09:35:31 +0200	[thread overview]
Message-ID: <1416555331.28873.8.camel@mm-sol.com> (raw)
In-Reply-To: <7e2f4984733343fdb4ea51cf7eb4c339@BY2FFO11FD046.protection.gbl>


On Thu, 2014-11-20 at 08:22 -0800, Sören Brinkmann wrote:
> 
> 
> Also, I hope all my changes here don't break the current behavior. So,
> those 27 driver should still be able to do what they currently do. But I
> hope they could migrated over to use the generic bindings only in the
> longer term, so that these custom properties disappear.
> 
> > > The pinctrl driver just assembles
> > > some data structure that has the information regarding custom properties
> > > and the core handles the rest.
> > 
> > Yup, that is nice. What will be really nice if it also handle custom,
> > "function", "groups" and "pins" properties. Otherwise most of the drivers
> > will not be able to benefit from this.
> 
> Why would you still need those? 

I don't need them :-). The point was that still majority of the drivers
will have custom parsing functions. It would be nice if we could fix
that too. I do understand that using custom "pins", "functions"... is
something which is deprecated, but if core parsing functions allow
passing custom strings for above purposes, in a similar way as your
proposal, it will be easier for those drivers to migrate, I believe.

Regards,
Ivan

  reply	other threads:[~2014-11-21  7:35 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 19:05 [PATCH 0/7] Pinctrl support for Zynq Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` [PATCH 1/7] pinctrl: pinconf-generic: Declare dt_params/conf_items const Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-11 12:00   ` Linus Walleij
2014-11-11 12:00     ` Linus Walleij
2014-11-11 12:00     ` Linus Walleij
2014-11-03 19:05 ` [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-05 13:56   ` Laurent Pinchart
2014-11-05 13:56     ` Laurent Pinchart
2014-11-05 13:56     ` Laurent Pinchart
2014-11-05 18:09     ` Sören Brinkmann
2014-11-05 18:09       ` Sören Brinkmann
2014-11-05 18:09       ` Sören Brinkmann
2014-11-05 18:17       ` Laurent Pinchart
2014-11-05 18:17         ` Laurent Pinchart
2014-11-05 18:17         ` Laurent Pinchart
2014-11-11 12:29     ` Linus Walleij
2014-11-11 12:29       ` Linus Walleij
2014-11-11 12:29       ` Linus Walleij
2014-11-12 18:43       ` Sören Brinkmann
2014-11-12 18:43         ` Sören Brinkmann
2014-11-12 18:43         ` Sören Brinkmann
2014-11-11 12:47   ` Linus Walleij
2014-11-11 12:47     ` Linus Walleij
2014-11-11 12:47     ` Linus Walleij
2014-11-12 18:46     ` Sören Brinkmann
2014-11-12 18:46       ` Sören Brinkmann
2014-11-12 18:46       ` Sören Brinkmann
2014-11-12 19:38     ` Sören Brinkmann
2014-11-12 19:38       ` Sören Brinkmann
2014-11-12 19:38       ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:12   ` Geert Uytterhoeven
2014-11-03 19:12     ` Geert Uytterhoeven
2014-11-03 19:12     ` Geert Uytterhoeven
2014-11-11 14:53   ` Linus Walleij
2014-11-11 14:53     ` Linus Walleij
2014-11-11 14:53     ` Linus Walleij
2014-11-18  8:50     ` Ivan T. Ivanov
2014-11-18  8:50       ` Ivan T. Ivanov
2014-11-18  8:50       ` Ivan T. Ivanov
2014-11-18 17:25       ` Sören Brinkmann
2014-11-18 17:25         ` Sören Brinkmann
2014-11-18 17:25         ` Sören Brinkmann
2014-11-19  7:49         ` Ivan T. Ivanov
2014-11-19  7:49           ` Ivan T. Ivanov
2014-11-19  7:49           ` Ivan T. Ivanov
2014-11-19 15:35           ` Sören Brinkmann
2014-11-19 15:35             ` Sören Brinkmann
2014-11-19 15:35             ` Sören Brinkmann
2014-11-20  8:06             ` Ivan T. Ivanov
2014-11-20  8:06               ` Ivan T. Ivanov
2014-11-20  8:06               ` Ivan T. Ivanov
2014-11-20 16:22               ` Sören Brinkmann
2014-11-20 16:22                 ` Sören Brinkmann
2014-11-20 16:22                 ` Sören Brinkmann
2014-11-21  7:35                 ` Ivan T. Ivanov [this message]
2014-11-21  7:35                   ` Ivan T. Ivanov
2014-11-21  7:35                   ` Ivan T. Ivanov
2014-11-22 16:06                   ` Sören Brinkmann
2014-11-22 16:06                     ` Sören Brinkmann
2014-11-22 16:06                     ` Sören Brinkmann
2014-11-24  8:52                     ` Ivan T. Ivanov
2014-11-24  8:52                       ` Ivan T. Ivanov
2014-11-24  8:52                       ` Ivan T. Ivanov
2014-11-27 17:53     ` Sören Brinkmann
2014-11-27 17:53       ` Sören Brinkmann
2014-11-27 17:53       ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 4/7] pinctrl: zynq: Document DT binding Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-05  3:35   ` Andreas Färber
2014-11-05  3:35     ` Andreas Färber
2014-11-05  3:35     ` Andreas Färber
2014-11-05 17:07     ` Sören Brinkmann
2014-11-05 17:07       ` Sören Brinkmann
2014-11-05 17:07       ` Sören Brinkmann
2014-11-11 15:00   ` Linus Walleij
2014-11-11 15:00     ` Linus Walleij
2014-11-11 15:00     ` Linus Walleij
2014-11-12 18:53     ` Sören Brinkmann
2014-11-12 18:53       ` Sören Brinkmann
2014-11-12 18:53       ` Sören Brinkmann
2014-11-27 13:10       ` Linus Walleij
2014-11-27 13:10         ` Linus Walleij
2014-11-27 13:10         ` Linus Walleij
2014-11-03 19:05 ` [PATCH 5/7] pinctrl: Add driver for Zynq Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-05  3:24   ` Andreas Färber
2014-11-05  3:24     ` Andreas Färber
2014-11-05  3:24     ` Andreas Färber
2014-11-05 17:10     ` Sören Brinkmann
2014-11-05 17:10       ` Sören Brinkmann
2014-11-05 17:10       ` Sören Brinkmann
2014-11-05  5:12   ` Andreas Färber
2014-11-05  5:12     ` Andreas Färber
2014-11-05  5:12     ` Andreas Färber
2014-11-05 17:14     ` Sören Brinkmann
2014-11-05 17:14       ` Sören Brinkmann
2014-11-05 17:14       ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 6/7] ARM: zynq: Enable pinctrl Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05 ` [PATCH 7/7] ARM: zynq: DT: Add pinctrl information Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-03 19:05   ` Soren Brinkmann
2014-11-05  5:56 ` [PATCH 0/7] Pinctrl support for Zynq Andreas Färber
2014-11-05  5:56   ` Andreas Färber
2014-11-05  5:56   ` Andreas Färber
2014-11-05 17:03   ` Sören Brinkmann
2014-11-05 17:03     ` Sören Brinkmann
2014-11-05 17:03     ` Sören Brinkmann
2014-11-06  3:51     ` Andreas Färber
2014-11-06  3:51       ` Andreas Färber
2014-11-06  3:51       ` Andreas Färber
2014-11-06  4:13       ` Sören Brinkmann
2014-11-06  4:13         ` Sören Brinkmann
2014-11-06  4:13         ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416555331.28873.8.camel@mm-sol.com \
    --to=iivanov@mm-sol.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.