From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@lst.de>,
Paolo@suse.de, "Bonzini <pbonzini"@redhat.com,
"David S. Miller" <davem@davemloft.net>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 04/12] esp_scsi: debug event and command
Date: Mon, 24 Nov 2014 15:37:22 +0100 [thread overview]
Message-ID: <1416839850-30475-5-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1416839850-30475-1-git-send-email-hare@suse.de>
Add new debug definitions for event and command logging.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/esp_scsi.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 10a3d17..3a5d81c 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -49,6 +49,8 @@ static u32 esp_debug;
#define ESP_DEBUG_DATADONE 0x00000100
#define ESP_DEBUG_RECONNECT 0x00000200
#define ESP_DEBUG_AUTOSENSE 0x00000400
+#define ESP_DEBUG_EVENT 0x00000800
+#define ESP_DEBUG_COMMAND 0x00001000
#define esp_log_intr(f, a...) \
do { if (esp_debug & ESP_DEBUG_INTR) \
@@ -100,6 +102,16 @@ do { if (esp_debug & ESP_DEBUG_AUTOSENSE) \
shost_printk(KERN_DEBUG, esp->host, f, ## a); \
} while (0)
+#define esp_log_event(f, a...) \
+do { if (esp_debug & ESP_DEBUG_EVENT) \
+ shost_printk(KERN_DEBUG, esp->host, f, ## a); \
+} while (0)
+
+#define esp_log_command(f, a...) \
+do { if (esp_debug & ESP_DEBUG_COMMAND) \
+ shost_printk(KERN_DEBUG, esp->host, f, ## a); \
+} while (0)
+
#define esp_read8(REG) esp->ops->esp_read8(esp, REG)
#define esp_write8(VAL,REG) esp->ops->esp_write8(esp, VAL, REG)
@@ -126,6 +138,7 @@ void scsi_esp_cmd(struct esp *esp, u8 val)
esp->esp_event_cur = (idx + 1) & (ESP_EVENT_LOG_SZ - 1);
+ esp_log_command("cmd[%02x]\n", val);
esp_write8(val, ESP_CMD);
}
EXPORT_SYMBOL(scsi_esp_cmd);
@@ -1638,6 +1651,8 @@ static int esp_process_event(struct esp *esp)
again:
write = 0;
+ esp_log_event("process event %d phase %x\n",
+ esp->event, esp->sreg & ESP_STAT_PMASK);
switch (esp->event) {
case ESP_EVENT_CHECK_PHASE:
switch (esp->sreg & ESP_STAT_PMASK) {
--
1.8.5.2
next prev parent reply other threads:[~2014-11-24 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:37 [PATCHv3 00/12] Re-implement am53c974 driver Hannes Reinecke
2014-11-24 14:37 ` [PATCH 01/12] esp_scsi: spellcheck 'driver' Hannes Reinecke
2014-11-24 14:37 ` [PATCH 02/12] esp_scsi: make number of tags configurable Hannes Reinecke
2014-11-24 14:37 ` [PATCH 03/12] esp_scsi: convert to dev_printk Hannes Reinecke
2014-11-24 14:37 ` Hannes Reinecke [this message]
2014-11-24 14:37 ` [PATCH 05/12] esp_scsi: read status registers Hannes Reinecke
2014-11-24 14:37 ` [PATCH 06/12] esp_scsi: use FIFO for command submission Hannes Reinecke
2014-11-24 14:37 ` [PATCH 07/12] scsi: add 'am53c974' driver Hannes Reinecke
2014-11-24 14:37 ` [PATCH 08/12] am53c974: BLAST residual handling Hannes Reinecke
2014-11-24 14:37 ` [PATCH 09/12] esp: correctly detect am53c974 Hannes Reinecke
2014-11-24 14:37 ` [PATCH 10/12] esp_scsi: let DMA driver provide a config2 value Hannes Reinecke
2014-11-24 14:37 ` [PATCH 11/12] esp: enable CONFIG2_FENAB for am53c974 Hannes Reinecke
2014-11-24 14:37 ` [PATCH 12/12] Replace tmscsim by am53c974 Hannes Reinecke
2014-11-24 15:18 ` [PATCHv3 00/12] Re-implement am53c974 driver Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-11-21 12:41 [PATCHv2 " Hannes Reinecke
2014-11-21 12:41 ` [PATCH 04/12] esp_scsi: debug event and command Hannes Reinecke
2014-11-21 17:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416839850-30475-5-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc="Bonzini <pbonzini"@redhat.com \
--cc=Paolo@suse.de \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.