All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Paolo@suse.de, "Bonzini <pbonzini"@redhat.com,
	"David S. Miller" <davem@davemloft.net>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 05/12] esp_scsi: read status registers
Date: Mon, 24 Nov 2014 15:37:23 +0100	[thread overview]
Message-ID: <1416839850-30475-6-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1416839850-30475-1-git-send-email-hare@suse.de>

A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read
all status registers in one go to avoid losing information.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/esp_scsi.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 3a5d81c..0ad0f08 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -982,7 +982,6 @@ static int esp_check_spur_intr(struct esp *esp)
 
 	default:
 		if (!(esp->sreg & ESP_STAT_INTR)) {
-			esp->ireg = esp_read8(ESP_INTRPT);
 			if (esp->ireg & ESP_INTR_SR)
 				return 1;
 
@@ -2056,7 +2055,12 @@ static void __esp_interrupt(struct esp *esp)
 	int finish_reset, intr_done;
 	u8 phase;
 
+       /*
+	* Once INTRPT is read STATUS and SSTEP are cleared.
+	*/
 	esp->sreg = esp_read8(ESP_STATUS);
+	esp->seqreg = esp_read8(ESP_SSTEP);
+	esp->ireg = esp_read8(ESP_INTRPT);
 
 	if (esp->flags & ESP_FLAG_RESETTING) {
 		finish_reset = 1;
@@ -2069,8 +2073,6 @@ static void __esp_interrupt(struct esp *esp)
 			return;
 	}
 
-	esp->ireg = esp_read8(ESP_INTRPT);
-
 	if (esp->ireg & ESP_INTR_SR)
 		finish_reset = 1;
 
-- 
1.8.5.2


  parent reply	other threads:[~2014-11-24 14:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 14:37 [PATCHv3 00/12] Re-implement am53c974 driver Hannes Reinecke
2014-11-24 14:37 ` [PATCH 01/12] esp_scsi: spellcheck 'driver' Hannes Reinecke
2014-11-24 14:37 ` [PATCH 02/12] esp_scsi: make number of tags configurable Hannes Reinecke
2014-11-24 14:37 ` [PATCH 03/12] esp_scsi: convert to dev_printk Hannes Reinecke
2014-11-24 14:37 ` [PATCH 04/12] esp_scsi: debug event and command Hannes Reinecke
2014-11-24 14:37 ` Hannes Reinecke [this message]
2014-11-24 14:37 ` [PATCH 06/12] esp_scsi: use FIFO for command submission Hannes Reinecke
2014-11-24 14:37 ` [PATCH 07/12] scsi: add 'am53c974' driver Hannes Reinecke
2014-11-24 14:37 ` [PATCH 08/12] am53c974: BLAST residual handling Hannes Reinecke
2014-11-24 14:37 ` [PATCH 09/12] esp: correctly detect am53c974 Hannes Reinecke
2014-11-24 14:37 ` [PATCH 10/12] esp_scsi: let DMA driver provide a config2 value Hannes Reinecke
2014-11-24 14:37 ` [PATCH 11/12] esp: enable CONFIG2_FENAB for am53c974 Hannes Reinecke
2014-11-24 14:37 ` [PATCH 12/12] Replace tmscsim by am53c974 Hannes Reinecke
2014-11-24 15:18 ` [PATCHv3 00/12] Re-implement am53c974 driver Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2014-11-21 12:41 [PATCHv2 " Hannes Reinecke
2014-11-21 12:41 ` [PATCH 05/12] esp_scsi: read status registers Hannes Reinecke
2014-11-21 17:44   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416839850-30475-6-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc="Bonzini <pbonzini"@redhat.com \
    --cc=Paolo@suse.de \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.