From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Mark Pryor <tlviewer@yahoo.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability
Date: Tue, 2 Dec 2014 15:15:16 +0000 [thread overview]
Message-ID: <1417533316.24320.57.camel@citrix.com> (raw)
In-Reply-To: <1417533090-29651-1-git-send-email-wei.liu2@citrix.com>
On Tue, 2014-12-02 at 15:11 +0000, Wei Liu wrote:
> AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is
> incorrect, even in the event systemd library is available. Use
> PKG_CHECK_MODULES instead.
>
> Tested on Debian Jessie and Arch Linux.
>
> Please rerun autogen.sh after applying this patch.
>
> Reported-by: Mark Pryor <tlviewer@yahoo.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Luis R. Rodriguez <mcgrof@do-not-panic.com>
> Cc: Mark Pryor <tlviewer@yahoo.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
I think you should make reference in the commit log to the fact that the
library has change name upstream but that a compatibility pkg-config is
provided for the old name.
It'd be nice if there was a less repetitive way to handle defaults +
overriding in the autoconf stuff, but for a freeze exception this is the
way to go.
Ian.
next prev parent reply other threads:[~2014-12-02 15:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:11 [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Wei Liu
2014-12-02 15:15 ` Ian Campbell [this message]
2014-12-02 18:37 ` Konrad Rzeszutek Wilk
2014-12-03 10:26 ` Olaf Hering
2014-12-03 10:28 ` Ian Campbell
2014-12-03 10:49 ` Olaf Hering
2014-12-03 10:51 ` Ian Campbell
2014-12-03 10:55 ` Olaf Hering
2014-12-03 21:05 ` Konrad Rzeszutek Wilk
2014-12-03 21:20 ` M A Young
2014-12-04 11:55 ` Ian Campbell
2014-12-05 9:51 ` Olaf Hering
2014-12-05 9:59 ` Ian Campbell
2014-12-05 10:02 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2014-12-04 12:13 Konrad Rzeszutek Wilk
2014-12-04 13:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417533316.24320.57.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mcgrof@do-not-panic.com \
--cc=tlviewer@yahoo.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.