From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Mark Pryor <tlviewer@yahoo.com>, Wei Liu <wei.liu2@citrix.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability
Date: Fri, 5 Dec 2014 11:02:35 +0100 [thread overview]
Message-ID: <20141205100235.GA18455@aepfle.de> (raw)
In-Reply-To: <1417773588.22808.52.camel@citrix.com>
On Fri, Dec 05, Ian Campbell wrote:
> On Fri, 2014-12-05 at 10:51 +0100, Olaf Hering wrote:
> > On Tue, Dec 02, Wei Liu wrote:
> >
> > > AC_CHECK_LIB fails on Debian Jessie since the ld flag it generates is
> > > incorrect, even in the event systemd library is available. Use
> > > PKG_CHECK_MODULES instead.
> > >
> > > Tested on Debian Jessie and Arch Linux.
> >
> > I just tested this and got this failure. The reason is that the LDFLAGS come
> > before the objects. If I move LDFLAGS after $^ linking works. Will send a patch
> > to fix the failure.
>
> Was this a new failure with this change? AFAICT LDFLAGS is still set
> (via SYSTEMD_LIBS) in the same place relative to non-systemd stuff.
No, happens even without it. I just realized that I missed a git rebase.
My own packages do not have systemd-devel yet, so I did not spot this
earlier. Maybe it just happens with the latest toolchain in Factory.
Last time it worked well in 13.1 at least, SLE12 was ok as well.
Olaf
next prev parent reply other threads:[~2014-12-05 10:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:11 [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Wei Liu
2014-12-02 15:15 ` Ian Campbell
2014-12-02 18:37 ` Konrad Rzeszutek Wilk
2014-12-03 10:26 ` Olaf Hering
2014-12-03 10:28 ` Ian Campbell
2014-12-03 10:49 ` Olaf Hering
2014-12-03 10:51 ` Ian Campbell
2014-12-03 10:55 ` Olaf Hering
2014-12-03 21:05 ` Konrad Rzeszutek Wilk
2014-12-03 21:20 ` M A Young
2014-12-04 11:55 ` Ian Campbell
2014-12-05 9:51 ` Olaf Hering
2014-12-05 9:59 ` Ian Campbell
2014-12-05 10:02 ` Olaf Hering [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-04 12:13 Konrad Rzeszutek Wilk
2014-12-04 13:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205100235.GA18455@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mcgrof@do-not-panic.com \
--cc=tlviewer@yahoo.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.