From: Ian Campbell <Ian.Campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Mark Pryor <tlviewer@yahoo.com>, Wei Liu <wei.liu2@citrix.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, m.a.young@durham.ac.uk,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability
Date: Thu, 4 Dec 2014 11:55:40 +0000 [thread overview]
Message-ID: <1417694140.22808.11.camel@citrix.com> (raw)
In-Reply-To: <1417603870.11243.10.camel@citrix.com>
On Wed, 2014-12-03 at 10:51 +0000, Ian Campbell wrote:
> On Wed, 2014-12-03 at 11:49 +0100, Olaf Hering wrote:
> > On Wed, Dec 03, Ian Campbell wrote:
> >
> > > Ah I didn't know about the sd_listen_fds thing, so I think that what we
> > > need then is to use pkg-config first to determine if systemd-daemon is
> > > present at all, and then check for specific symbols we require using the
> > > pkg-config supplied CFLAGS and LDFLAGS rather than assuming
> > > -lsystemd-daemon.
> >
> > Correction: sd_listen_fds is available since at least v1.
> > git describe --contains abbbea81a8fa70badb7a05e518d6b07c360fc09d
> > v1~390
>
> In that case I don't think we realistically need to check for it?
The implication here being that Wei's original patch is correct. Konrad,
do you think this is OK for the release?
>
> Ian.
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-12-04 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:11 [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability Wei Liu
2014-12-02 15:15 ` Ian Campbell
2014-12-02 18:37 ` Konrad Rzeszutek Wilk
2014-12-03 10:26 ` Olaf Hering
2014-12-03 10:28 ` Ian Campbell
2014-12-03 10:49 ` Olaf Hering
2014-12-03 10:51 ` Ian Campbell
2014-12-03 10:55 ` Olaf Hering
2014-12-03 21:05 ` Konrad Rzeszutek Wilk
2014-12-03 21:20 ` M A Young
2014-12-04 11:55 ` Ian Campbell [this message]
2014-12-05 9:51 ` Olaf Hering
2014-12-05 9:59 ` Ian Campbell
2014-12-05 10:02 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2014-12-04 12:13 Konrad Rzeszutek Wilk
2014-12-04 13:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417694140.22808.11.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=mcgrof@do-not-panic.com \
--cc=olaf@aepfle.de \
--cc=tlviewer@yahoo.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.