Xen-ringwatch generating many alerts

Xen-ringwatch generating many alerts

[vishalfaldu]

Hi ,

We have xen-ringwatch which is sending below alert frequently, Any one can
help ?

Subject: Cron <root@DOM0> xen-ringwatch check -T3 --kick | logger -p
daemon.crit -t RINGWATCH-ALERT
To: root


Traceback (most recent call last):
  File "/usr/sbin/xen-ringwatch", line 593, in ?
    watches.update()
  File "/usr/sbin/xen-ringwatch", line 414, in update
    entry = RingWatch.new(ring)
  File "/usr/sbin/xen-ringwatch", line 357, in new
    state = ring.read()
  File "/usr/sbin/xen-ringwatch", line 136, in read
    state = RingState.from_sysfs(self.path())
  File "/usr/sbin/xen-ringwatch", line 223, in from_sysfs
    req = cls.Req.from_sysfs(_req, size=nr_ents)
  File "/usr/sbin/xen-ringwatch", line 240, in from_sysfs
    raise Exception, "Malformed %s input: %s" % \
NameError: global name 's' is not defined






--
View this message in context: http://xen.1045712.n5.nabble.com/Xen-ringwatch-generating-many-alerts-tp5725675.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Xen-ringwatch generating many alerts

[Ian Campbell]

On Wed, 2015-01-07 at 22:54 -0700, vishalfaldu wrote:
> Hi ,
> 
> We have xen-ringwatch which is sending below alert frequently, Any one can
> help ?
> 
> Subject: Cron <root@DOM0> xen-ringwatch check -T3 --kick | logger -p
> daemon.crit -t RINGWATCH-ALERT
> To: root
> 
> 
> Traceback (most recent call last):
>   File "/usr/sbin/xen-ringwatch", line 593, in ?
>     watches.update()
>   File "/usr/sbin/xen-ringwatch", line 414, in update
>     entry = RingWatch.new(ring)
>   File "/usr/sbin/xen-ringwatch", line 357, in new
>     state = ring.read()
>   File "/usr/sbin/xen-ringwatch", line 136, in read
>     state = RingState.from_sysfs(self.path())
>   File "/usr/sbin/xen-ringwatch", line 223, in from_sysfs
>     req = cls.Req.from_sysfs(_req, size=nr_ents)
>   File "/usr/sbin/xen-ringwatch", line 240, in from_sysfs
>     raise Exception, "Malformed %s input: %s" % \
> NameError: global name 's' is not defined

It seems like there is a bug in the  error handling at line 240, repr(s)
ought to be repr(line), I think. If you fix that (and please do send a
patch if you do, see [0]) then I expect you'll get a more useful error
message.

Ian.

[0] http://wiki.xen.org/wiki/Submitting_Xen_Patches