From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: oleksandr.tyshchenko@globallogic.com,
Iurii Konovalenko <iurii.konovalenko@globallogic.com>,
stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH v1 1/3] xen/arm: Add R-Car Gen2 support for early printk
Date: Fri, 16 Jan 2015 13:08:44 +0000 [thread overview]
Message-ID: <1421413724.19839.62.camel@citrix.com> (raw)
In-Reply-To: <54B90C84.5030106@linaro.org>
On Fri, 2015-01-16 at 13:05 +0000, Julien Grall wrote:
> Hello Iurii,
>
> Thanks for adding the support of a new board in Xen.
>
> On 16/01/15 12:50, Iurii Konovalenko wrote:
> > diff --git a/xen/include/asm-arm/rcar2-uart.h b/xen/include/asm-arm/rcar2-uart.h
> > new file mode 100644
> > index 0000000..10a56fb
> > --- /dev/null
> > +++ b/xen/include/asm-arm/rcar2-uart.h
>
> [..]
>
> > +#ifndef __ASM_ARM_RCAR2_H
> > +#define __ASM_ARM_RCAR2_H
>
> According to the name of the guard should be called __ASM_ARM_RCAR2_UART_H
Is RCAR2 the name of the board, the soc or the name of uart IP block?
I'd prefer the naming (here and for the main driver) to be as far to the
right of that list as possible.
Ian.
next prev parent reply other threads:[~2015-01-16 13:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 12:50 [PATCH v1 0/3] arm: introduce basic Renesas R-Car Gen2 platform support Iurii Konovalenko
2015-01-16 12:50 ` [PATCH v1 1/3] xen/arm: Add R-Car Gen2 support for early printk Iurii Konovalenko
2015-01-16 13:05 ` Julien Grall
2015-01-16 13:08 ` Ian Campbell [this message]
2015-01-16 13:11 ` Julien Grall
2015-01-16 13:15 ` Ian Campbell
2015-01-16 13:26 ` Oleksandr Tyshchenko
2015-01-16 13:36 ` Ian Campbell
2015-01-16 12:50 ` [PATCH v1 2/3] xen/arm: Add new driver for R-Car Gen2 UART Iurii Konovalenko
2015-01-16 13:19 ` Julien Grall
2015-01-16 15:53 ` Oleksandr Tyshchenko
2015-01-16 12:50 ` [PATCH v1 3/3] xen/arm: Introduce support for Renesas R-Car Gen2 platform Iurii Konovalenko
2015-01-16 14:08 ` Julien Grall
2015-01-16 15:29 ` Iurii Konovalenko
2015-01-16 15:32 ` Julien Grall
2015-01-16 16:17 ` Iurii Konovalenko
2015-01-16 16:31 ` Julien Grall
2015-01-16 19:11 ` Iurii Konovalenko
2015-01-16 19:34 ` Julien Grall
2015-01-17 20:55 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421413724.19839.62.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=julien.grall@linaro.org \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.