From: Julien Grall <julien.grall@linaro.org>
To: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
Cc: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
tim@xen.org, Ian Campbell <ian.campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v1 3/3] xen/arm: Introduce support for Renesas R-Car Gen2 platform
Date: Fri, 16 Jan 2015 15:32:51 +0000 [thread overview]
Message-ID: <54B92F23.7060507@linaro.org> (raw)
In-Reply-To: <CABc08zLAYjBcrHitR1wmP5rVOp9dHA4eMzyvo1cU+xKwDPatXA@mail.gmail.com>
On 16/01/15 15:29, Iurii Konovalenko wrote:
>> Is there any reason that this code diverge?
>>
>
> Linux kernel 3.14-ltsi, which I used as a reference, use CNTFID0
> in file arch/arm/mach-shmobile/setup-rcar-gen2.c:
> iowrite32(freq, base + CNTFID0);
Which seems different from upstream:
1. /* Update registers with correct frequency */
2. iowrite32(freq, base + CNTFID0);
3. asm volatile("mcr p15, 0, %0, c14, c0, 0" : : "r" (freq));
4.
5. /* make sure arch timer is started by setting bit 0 of CNTCR */
6. iowrite32(1, base + CNTCR);
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-01-16 15:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 12:50 [PATCH v1 0/3] arm: introduce basic Renesas R-Car Gen2 platform support Iurii Konovalenko
2015-01-16 12:50 ` [PATCH v1 1/3] xen/arm: Add R-Car Gen2 support for early printk Iurii Konovalenko
2015-01-16 13:05 ` Julien Grall
2015-01-16 13:08 ` Ian Campbell
2015-01-16 13:11 ` Julien Grall
2015-01-16 13:15 ` Ian Campbell
2015-01-16 13:26 ` Oleksandr Tyshchenko
2015-01-16 13:36 ` Ian Campbell
2015-01-16 12:50 ` [PATCH v1 2/3] xen/arm: Add new driver for R-Car Gen2 UART Iurii Konovalenko
2015-01-16 13:19 ` Julien Grall
2015-01-16 15:53 ` Oleksandr Tyshchenko
2015-01-16 12:50 ` [PATCH v1 3/3] xen/arm: Introduce support for Renesas R-Car Gen2 platform Iurii Konovalenko
2015-01-16 14:08 ` Julien Grall
2015-01-16 15:29 ` Iurii Konovalenko
2015-01-16 15:32 ` Julien Grall [this message]
2015-01-16 16:17 ` Iurii Konovalenko
2015-01-16 16:31 ` Julien Grall
2015-01-16 19:11 ` Iurii Konovalenko
2015-01-16 19:34 ` Julien Grall
2015-01-17 20:55 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B92F23.7060507@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.