[Patch] static symbols in credit2

[Patch] static symbols in credit2

[Uma Sharma]

Changing param varibales in sched_credit2.c as static where required.

Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>

---
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index 1ca521b..9dd8e84 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -163,7 +163,7 @@
 #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request)
 
 
-int opt_migrate_resist=500;
+static int opt_migrate_resist = 500;
 integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
 
 /*
@@ -186,12 +186,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
  *   to a load of 1.
  */
 #define LOADAVG_GRANULARITY_SHIFT (10)
-int opt_load_window_shift=18;
+static int opt_load_window_shift = 18;
 #define  LOADAVG_WINDOW_SHIFT_MIN 4
 integer_param("credit2_load_window_shift", opt_load_window_shift);
-int opt_underload_balance_tolerance=0;
+static int opt_underload_balance_tolerance = 0;
 integer_param("credit2_balance_under", opt_underload_balance_tolerance);
-int opt_overload_balance_tolerance=-3;
+static int opt_overload_balance_tolerance = -3;
 integer_param("credit2_balance_over", opt_overload_balance_tolerance);
 
 /*

Re: [Patch] static symbols in credit2

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1526 bytes --]

Hi Uma,

AFAICT, this is the second version of the patch, that you produced after
receiving feedback on your first submission, isn't it? In that case, you
should make that evident in the subject, using something like "[PATCH
v2]"

On Wed, 2015-01-14 at 22:30 +0530, Uma Sharma wrote:
> Changing param varibales in sched_credit2.c as static where required.
> 
> Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>
> 
> ---
>
And also, you should put a summary of what changed in this new
submission, wrt the previous one(s). We usually put it here, in the
changelog, below the '---' marker.

In this case, that is pretty straightforward, but please do, if only to
get used to it! :-)

> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 1ca521b..9dd8e84 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -163,7 +163,7 @@
>  #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request)
>  
> 
> -int opt_migrate_resist=500;
> +static int opt_migrate_resist = 500;
>  integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
>  
Sorry for mentioning this only now, but, what about "__read_mostly" as
an attribute (for others too) ?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Patch] static symbols in credit2

[George Dunlap]

On Wed, Jan 14, 2015 at 5:00 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
> Changing param varibales in sched_credit2.c as static where required.
>
> Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>

Sorry for the delay -- everything looks good code-wise; but it
probably makes sense to send v3 with Dario's suggestions.

 -George

Re: [Patch] static symbols in credit2

[Uma Sharma]

[-- Attachment #1.1: Type: text/plain, Size: 495 bytes --]

Hi,

Dariof, I am not able to understand the last statement.
 On 21 Jan 2015 20:15, "George Dunlap" <George.Dunlap@eu.citrix.com> wrote:

> On Wed, Jan 14, 2015 at 5:00 PM, Uma Sharma <uma.sharma523@gmail.com>
> wrote:
> > Changing param varibales in sched_credit2.c as static where required.
> >
> > Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>
>
> Sorry for the delay -- everything looks good code-wise; but it
> probably makes sense to send v3 with Dario's suggestions.
>
>  -George
>

[-- Attachment #1.2: Type: text/html, Size: 910 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Patch] static symbols in credit2

[Uma Sharma]

Hi,

Sorry for being less responsive these days. Was facing some health
issues (cold).
Hope I can start work from tomorrow. :-)

Sorry Dariof I did not get this statement "what about "__read_mostly"
as an attribute (for others too) ?"
Is it about making other variables __initdata ?


On Thu, Jan 22, 2015 at 3:28 PM, Uma Sharma <uma.sharma523@gmail.com> wrote:
> Hi,
>
> Dariof, I am not able to understand the last statement.
>
> On 21 Jan 2015 20:15, "George Dunlap" <George.Dunlap@eu.citrix.com> wrote:
>>
>> On Wed, Jan 14, 2015 at 5:00 PM, Uma Sharma <uma.sharma523@gmail.com>
>> wrote:
>> > Changing param varibales in sched_credit2.c as static where required.
>> >
>> > Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>
>>
>> Sorry for the delay -- everything looks good code-wise; but it
>> probably makes sense to send v3 with Dario's suggestions.
>>
>>  -George



-- 
Regards,
Uma Sharma
http://about.me/umasharma