From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Olaf Hering <olaf@aepfle.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] hvmloader: remove timestamp from vgabios
Date: Tue, 3 Feb 2015 16:18:46 +0000 [thread overview]
Message-ID: <1422980326.9323.123.camel@citrix.com> (raw)
In-Reply-To: <54D0F202.2070209@citrix.com>
On Tue, 2015-02-03 at 16:06 +0000, Andrew Cooper wrote:
> On 03/02/15 15:54, Olaf Hering wrote:
> > Including a timestamp into the binary makes it impossible to get
> > reproducible binaries. Remove the timestamp because it carries no
> > valuable info.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
>
> In this case, it would appear that the vgabios_date symbol is completely
> unused inside the binary. Good riddance!
I think it is actually used because the string at vgabios_version
(deliberately) falls through.
Olof, you just removed the nul terminator used there AFAICT. At best
this means that the vgabios_copyright is printed twice.
Ian.
next prev parent reply other threads:[~2015-02-03 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 15:54 [PATCH 0/2] remove timestamp from hvmloader for reproducible build Olaf Hering
2015-02-03 15:54 ` [PATCH 1/2] hvmloader: remove timestamp from smbios Olaf Hering
2015-02-03 16:02 ` Andrew Cooper
2015-02-03 16:15 ` Jan Beulich
2015-02-03 16:23 ` Andrew Cooper
2015-02-03 16:57 ` Jan Beulich
2015-02-03 18:41 ` Olaf Hering
2015-02-04 8:34 ` Jan Beulich
2015-02-04 8:42 ` Olaf Hering
2015-02-04 9:04 ` Jan Beulich
2015-02-03 16:05 ` Ian Campbell
2015-02-03 15:54 ` [PATCH 2/2] hvmloader: remove timestamp from vgabios Olaf Hering
2015-02-03 16:06 ` Andrew Cooper
2015-02-03 16:17 ` Jan Beulich
2015-02-03 16:28 ` Ian Campbell
2015-02-03 16:43 ` Jan Beulich
2015-02-03 16:18 ` Ian Campbell [this message]
2015-02-03 16:23 ` Andrew Cooper
2015-02-03 16:29 ` Ian Campbell
2015-02-03 18:43 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422980326.9323.123.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.