From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 1/2] hvmloader: remove timestamp from smbios
Date: Wed, 4 Feb 2015 09:42:45 +0100 [thread overview]
Message-ID: <20150204084245.GA17993@aepfle.de> (raw)
In-Reply-To: <54D1E7B9020000780005CAC7@mail.emea.novell.com>
On Wed, Feb 04, Jan Beulich wrote:
> http://dmtf.org/sites/default/files/standards/documents/DSP0134_2.8.0.pdf
> (in particular section 7.1 and table 5)
"The date string, if supplied, is in either mm/dd/yy or mm/dd/yyyy format."
To me it sounds like an optional thing. An empty string is as
informative as any other random date.
But before the bikeshedding starts I think its best to turn the
assignment in the Makefiles from "VAR = VAL" into "VAR ?= VAL". This
preserves existing practice and gives us the opportunity to pass
01/01/1970 as fixed VAL.
Olaf
next prev parent reply other threads:[~2015-02-04 8:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 15:54 [PATCH 0/2] remove timestamp from hvmloader for reproducible build Olaf Hering
2015-02-03 15:54 ` [PATCH 1/2] hvmloader: remove timestamp from smbios Olaf Hering
2015-02-03 16:02 ` Andrew Cooper
2015-02-03 16:15 ` Jan Beulich
2015-02-03 16:23 ` Andrew Cooper
2015-02-03 16:57 ` Jan Beulich
2015-02-03 18:41 ` Olaf Hering
2015-02-04 8:34 ` Jan Beulich
2015-02-04 8:42 ` Olaf Hering [this message]
2015-02-04 9:04 ` Jan Beulich
2015-02-03 16:05 ` Ian Campbell
2015-02-03 15:54 ` [PATCH 2/2] hvmloader: remove timestamp from vgabios Olaf Hering
2015-02-03 16:06 ` Andrew Cooper
2015-02-03 16:17 ` Jan Beulich
2015-02-03 16:28 ` Ian Campbell
2015-02-03 16:43 ` Jan Beulich
2015-02-03 16:18 ` Ian Campbell
2015-02-03 16:23 ` Andrew Cooper
2015-02-03 16:29 ` Ian Campbell
2015-02-03 18:43 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204084245.GA17993@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.