From: Olaf Hering <olaf@aepfle.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] hvmloader: remove timestamp from smbios
Date: Tue, 3 Feb 2015 19:41:36 +0100 [thread overview]
Message-ID: <20150203184136.GA29901@aepfle.de> (raw)
In-Reply-To: <54D0F121.70107@citrix.com>
On Tue, Feb 03, Andrew Cooper wrote:
> A release date is part of the SMBIOS spec, and the change below results
> in a malformed smbios table (stale p->release_date_str = 3; pointer)
Good point. Thanks for review. Do you have a pointer to that spec?
> A better approach would be to derive the date from the commit date of
> HEAD, which would be consistent across rebuilds.
Releases dont have a HEAD. I will adjust the patch.
Olaf
next prev parent reply other threads:[~2015-02-03 18:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 15:54 [PATCH 0/2] remove timestamp from hvmloader for reproducible build Olaf Hering
2015-02-03 15:54 ` [PATCH 1/2] hvmloader: remove timestamp from smbios Olaf Hering
2015-02-03 16:02 ` Andrew Cooper
2015-02-03 16:15 ` Jan Beulich
2015-02-03 16:23 ` Andrew Cooper
2015-02-03 16:57 ` Jan Beulich
2015-02-03 18:41 ` Olaf Hering [this message]
2015-02-04 8:34 ` Jan Beulich
2015-02-04 8:42 ` Olaf Hering
2015-02-04 9:04 ` Jan Beulich
2015-02-03 16:05 ` Ian Campbell
2015-02-03 15:54 ` [PATCH 2/2] hvmloader: remove timestamp from vgabios Olaf Hering
2015-02-03 16:06 ` Andrew Cooper
2015-02-03 16:17 ` Jan Beulich
2015-02-03 16:28 ` Ian Campbell
2015-02-03 16:43 ` Jan Beulich
2015-02-03 16:18 ` Ian Campbell
2015-02-03 16:23 ` Andrew Cooper
2015-02-03 16:29 ` Ian Campbell
2015-02-03 18:43 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203184136.GA29901@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.