Re: [PATCH] st: implement sysfs based tape statistics v2

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Thu, 2015-02-05 at 19:46 +0200, "Kai Mäkisara (Kolumbus)" wrote:
> > On 5.2.2015, at 19.40, Laurence Oberman <loberman@redhat.com> wrote:
> > I missed the earlier conversations with James, I will go search for them.
> > Do you mean add them so they are similar to the /proc/diskstats
> > 
> > cat /proc/diskstats
> > ..
> >   8       0 sda 2258346 152801 291907067 5263795 388817 1518048 15013833 4542062 0 4794931 9803495
> >   8       1 sda1 717 102 26154 1179 8 2 80 76 0 1172 1254
> >   8       2 sda2 328 31 2872 1554 0 0 0 0 0 1554 1554
> >   8       3 sda3 2195205 151617 290898283 5203627 355053 1518046 15009528 4370598 0 4594137 9571937
> >   8       4 sda4 61921 1050 978350 57218 18 0 4225 34 0 56384 57185
> >  11       0 sr0 0 0 0 0 0 0 0 0 0 0 0
> > ..
> > 
> Not exactly. I mean the data exported in sysfs, for example:
> 
> > cat /sys/block/sda/sda1/stat
>   159740     9006  5941506    64461   124724    55907 12772208  3598677        0   299875  3663235

The problem is we're going to be attacked by the sysfs one value per
file crowd if we do something like this.  Block gets away with it
because it was grandfathered in.  It's only 12 files ... if there's a
good reason for having the fight with the sysfs people, we can; however,
I haven't seen a good reason yet, so I'd rather avoid creating a fuss
over something we're going to lose.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html