All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Linton <jlinton@tributary.com>
To: "Seymour, Shane M" <shane.seymour@hp.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "Kai.Makisara@kolumbus.fi" <Kai.Makisara@kolumbus.fi>,
	"James E.J. Bottomley (JBottomley@parallels.com)"
	<JBottomley@parallels.com>, "jeffm@suse.com" <jeffm@suse.com>
Subject: Re: [PATCH] st: implement sysfs based tape statistics v2
Date: Fri, 6 Feb 2015 11:49:52 -0600	[thread overview]
Message-ID: <54D4FEC0.8090101@tributary.com> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB3BF3C359@G9W0766.americas.hpqcorp.net>

On 1/26/2015 6:11 PM, Seymour, Shane M wrote:
> I was wondering if anyone had any feedback or had any chance to review the changes?

	Per the other discussion about having the same stat format forever. It seems to
me that you might want to preemptively add a few additional counters.
	
A counter for WRITE_FILEMARKS, particularly non immediate count=0 ones, which
are often used to flush the drive write buffer. A counter for movement related
commands like SPACE/LOCATE/REWIND would also be helpful. Finally, abnormal read
conditions like, ILI's, and hit FMs should have their own stat. Those three
should provide a better view into how the drive is being used and why
performance may not be what is expected.

There may be others, but those three are high on my list of things I want to
know about a tape stream that is not performing up to expectations.






  reply	other threads:[~2015-02-06 17:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  3:43 [PATCH] st: implement sysfs based tape statistics v2 Seymour, Shane M
2015-01-27  0:11 ` Seymour, Shane M
2015-02-06 17:49   ` Jeremy Linton [this message]
2015-02-02 15:16 ` Laurence Oberman
2015-02-05 17:03   ` "Kai Mäkisara (Kolumbus)"
2015-02-05 17:40     ` Laurence Oberman
2015-02-05 17:46       ` "Kai Mäkisara (Kolumbus)"
2015-02-05 18:12         ` Laurence Oberman
2015-02-05 18:43         ` James Bottomley
2015-02-05 18:50         ` Bryn M. Reeves
2015-02-05 18:55           ` James Bottomley
2015-02-05 18:57             ` Bryn M. Reeves
2015-02-08 17:07 ` Dale R. Worley
2015-02-08 23:19   ` Seymour, Shane M
2015-02-11  3:38     ` Dale R. Worley
2015-02-09  6:00   ` Seymour, Shane M
2015-02-09 19:14     ` "Kai Mäkisara (Kolumbus)"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D4FEC0.8090101@tributary.com \
    --to=jlinton@tributary.com \
    --cc=JBottomley@parallels.com \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=jeffm@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=shane.seymour@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.