Re: [PATCH] st: implement sysfs based tape statistics v2

[Laurence Oberman <loberman@redhat.com>]

----- Original Message -----
From: "Kai Mäkisara (Kolumbus)" <kai.makisara@kolumbus.fi>
To: "Laurence Oberman" <loberman@redhat.com>
Cc: "Laurence Oberman" <oberman.l@gmail.com>, "Shane M Seymour" <shane.seymour@hp.com>, linux-scsi@vger.kernel.org, "James E.J. Bottomley (JBottomley@parallels.com)" <JBottomley@parallels.com>, jeffm@suse.com
Sent: Thursday, February 5, 2015 12:46:32 PM
Subject: Re: [PATCH] st: implement sysfs based tape statistics v2


> On 5.2.2015, at 19.40, Laurence Oberman <loberman@redhat.com> wrote:
> 
> ----- Original Message -----
> From: "Kai Mäkisara (Kolumbus)" <kai.makisara@kolumbus.fi>
> To: "Laurence Oberman" <oberman.l@gmail.com>
> Cc: "Shane M Seymour" <shane.seymour@hp.com>, loberman@redhat.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley (JBottomley@parallels.com)" <JBottomley@parallels.com>, jeffm@suse.com
> Sent: Thursday, February 5, 2015 12:03:29 PM
> Subject: Re: [PATCH] st: implement sysfs based tape statistics v2
> 
> 
>> On 2.2.2015, at 17.16, Laurence Oberman <oberman.l@gmail.com> wrote:
>> 
>> I pulled this this morning and will be testing. The prior version was
>> stable for me on the upstream and RHEL 6.5 kernel without exhaustive
>> testing.
>> We also just received more requests to get this into RHEL from HP /
>> Red Hat customers.
>> 
>> Kai, what are your thoughts. I realize this is a large amount of
>> additional code. I am not keen to create a driver just for stats as we
>> would have to keep the rest of the st driver changes always in sync.
>> 
> 
> I still think that the tape statistics should be exported like the statistics of “real” block devices, i.e., one sysfs file exporting on a single line the statistics that temporally belong together. James rejected this approach. I am leaving the decision about this code to him. I will neither ack nor nak this code.
> 
> Thanks,
> Kai
> 
> Hello Kai,
> 
> I missed the earlier conversations with James, I will go search for them.
> Do you mean add them so they are similar to the /proc/diskstats
> 
> cat /proc/diskstats
> ..
>   8       0 sda 2258346 152801 291907067 5263795 388817 1518048 15013833 4542062 0 4794931 9803495
>   8       1 sda1 717 102 26154 1179 8 2 80 76 0 1172 1254
>   8       2 sda2 328 31 2872 1554 0 0 0 0 0 1554 1554
>   8       3 sda3 2195205 151617 290898283 5203627 355053 1518046 15009528 4370598 0 4594137 9571937
>   8       4 sda4 61921 1050 978350 57218 18 0 4225 34 0 56384 57185
>  11       0 sr0 0 0 0 0 0 0 0 0 0 0 0
> ..
> 
Not exactly. I mean the data exported in sysfs, for example:

> cat /sys/block/sda/sda1/stat
  159740     9006  5941506    64461   124724    55907 12772208  3598677        0   299875  3663235

Kai

Ok, Thanks, got it now. Let me circle back with Shane

Laurence Oberman
Red Hat Global Support Service
SEG Team
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html