All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Michael Neuling <mikey@neuling.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl: Remove useless precision specifiers
Date: Sun, 22 Feb 2015 22:42:11 -0800	[thread overview]
Message-ID: <1424673731.20944.24.camel@perches.com> (raw)
In-Reply-To: <1424662685-sup-6648@delenn.ozlabs.ibm.com>

On Mon, 2015-02-23 at 14:40 +1100, Ian Munsie wrote:
> Excerpts from Rasmus Villemoes's message of 2015-02-21 00:26:22 +1100:
> > C99 says that a precision given as simply '.' with no following digits
> > or * should be interpreted as 0. The kernel's printf implementation,
> > however, treats this case as if the precision was omitted. C99 also
> > says that if both the precision and value are 0, no digits should be
> > printed. Even if the kernel followed C99 to the letter, I don't think
> > that would be particularly useful in these cases, so just remove the
> > precision specifiers.
> 
> Nice catch Rasmus, but I think a better patch would be one that adds the
> missing precision (%.16llx).

The kernel much more commonly uses %016llx

$ git grep "%016llx" | grep -v staging | wc -l
792
$ git grep "%\.16llx" | grep -v staging | wc -l
36

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Michael Neuling <mikey@neuling.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl: Remove useless precision specifiers
Date: Sun, 22 Feb 2015 22:42:11 -0800	[thread overview]
Message-ID: <1424673731.20944.24.camel@perches.com> (raw)
In-Reply-To: <1424662685-sup-6648@delenn.ozlabs.ibm.com>

On Mon, 2015-02-23 at 14:40 +1100, Ian Munsie wrote:
> Excerpts from Rasmus Villemoes's message of 2015-02-21 00:26:22 +1100:
> > C99 says that a precision given as simply '.' with no following digits
> > or * should be interpreted as 0. The kernel's printf implementation,
> > however, treats this case as if the precision was omitted. C99 also
> > says that if both the precision and value are 0, no digits should be
> > printed. Even if the kernel followed C99 to the letter, I don't think
> > that would be particularly useful in these cases, so just remove the
> > precision specifiers.
> 
> Nice catch Rasmus, but I think a better patch would be one that adds the
> missing precision (%.16llx).

The kernel much more commonly uses %016llx

$ git grep "%016llx" | grep -v staging | wc -l
792
$ git grep "%\.16llx" | grep -v staging | wc -l
36



  reply	other threads:[~2015-02-23  6:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 13:26 [PATCH] cxl: Remove useless precision specifiers Rasmus Villemoes
2015-02-20 13:26 ` Rasmus Villemoes
2015-02-23  3:40 ` Ian Munsie
2015-02-23  6:42   ` Joe Perches [this message]
2015-02-23  6:42     ` Joe Perches
2015-02-23 10:55   ` [PATCH v2] cxl: Add explicit " Rasmus Villemoes
2015-02-23 10:55     ` Rasmus Villemoes
2015-02-23 14:59     ` Joe Perches
2015-02-23 14:59       ` Joe Perches
2015-02-24  0:12       ` Michael Ellerman
2015-02-24  0:12         ` Michael Ellerman
2015-02-24  4:28       ` Ian Munsie
2015-02-24  4:28         ` Ian Munsie
2015-06-11 11:27         ` [PATCH v3 1/2] " Rasmus Villemoes
2015-06-11 11:27           ` [PATCH v3 2/2] cxl: use more common format specifier Rasmus Villemoes
2015-06-12  1:08             ` Ian Munsie
2015-07-16  9:59           ` [v3,1/2] cxl: Add explicit precision specifiers Michael Ellerman
2015-02-24  4:25     ` [PATCH v2] " Ian Munsie
2015-02-24  4:25       ` Ian Munsie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424673731.20944.24.camel@perches.com \
    --to=joe@perches.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.