* [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof
@ 2015-03-05 1:43 Axel Lin
2015-03-05 1:44 ` [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO Axel Lin
2015-03-05 9:00 ` [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Gabriel Fernandez
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2015-03-05 1:43 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Gabriel FERNANDEZ, kernel@vger.kernel.org, Alexandre Torgue
Prefer devm_kcalloc over devm_kzalloc with multiply.
In additional, use sizeof(phy) is incorrect, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
This patch is on top of below patch:
[PATCH 1/2] phy: miphy28lp: Avoid calling of_get_child_count() multiple times
drivers/phy/phy-miphy28lp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
index 4fe1755..9334352 100644
--- a/drivers/phy/phy-miphy28lp.c
+++ b/drivers/phy/phy-miphy28lp.c
@@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev)
return -ENOMEM;
miphy_dev->nphys = of_get_child_count(np);
- miphy_dev->phys = devm_kzalloc(&pdev->dev,
- sizeof(phy) * miphy_dev->nphys,
- GFP_KERNEL);
+ miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
+ sizeof(*miphy_dev->phys), GFP_KERNEL);
if (!miphy_dev->phys)
return -ENOMEM;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO
2015-03-05 1:43 [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Axel Lin
@ 2015-03-05 1:44 ` Axel Lin
2015-03-05 9:00 ` Gabriel Fernandez
2015-03-05 9:00 ` [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Gabriel Fernandez
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2015-03-05 1:44 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Gabriel FERNANDEZ, kernel@vger.kernel.org, Alexandre Torgue
PTR_ERR_OR_ZERO simplifies the code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-miphy28lp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
index 9334352..c4cc11d 100644
--- a/drivers/phy/phy-miphy28lp.c
+++ b/drivers/phy/phy-miphy28lp.c
@@ -1259,10 +1259,7 @@ static int miphy28lp_probe(struct platform_device *pdev)
}
provider = devm_of_phy_provider_register(&pdev->dev, miphy28lp_xlate);
- if (IS_ERR(provider))
- return PTR_ERR(provider);
-
- return 0;
+ return PTR_ERR_OR_ZERO(provider);
}
static const struct of_device_id miphy28lp_of_match[] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO
2015-03-05 1:44 ` [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO Axel Lin
@ 2015-03-05 9:00 ` Gabriel Fernandez
0 siblings, 0 replies; 4+ messages in thread
From: Gabriel Fernandez @ 2015-03-05 9:00 UTC (permalink / raw)
To: Axel Lin, Kishon Vijay Abraham I; +Cc: kernel@vger.kernel.org, Alexandre Torgue
Acked-by: Gabriel Fernandez<gabriel.fernandez@linaro.org>
On 03/05/2015 02:44 AM, Axel Lin wrote:
> PTR_ERR_OR_ZERO simplifies the code.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/phy/phy-miphy28lp.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
> index 9334352..c4cc11d 100644
> --- a/drivers/phy/phy-miphy28lp.c
> +++ b/drivers/phy/phy-miphy28lp.c
> @@ -1259,10 +1259,7 @@ static int miphy28lp_probe(struct platform_device *pdev)
> }
>
> provider = devm_of_phy_provider_register(&pdev->dev, miphy28lp_xlate);
> - if (IS_ERR(provider))
> - return PTR_ERR(provider);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(provider);
> }
>
> static const struct of_device_id miphy28lp_of_match[] = {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof
2015-03-05 1:43 [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Axel Lin
2015-03-05 1:44 ` [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO Axel Lin
@ 2015-03-05 9:00 ` Gabriel Fernandez
1 sibling, 0 replies; 4+ messages in thread
From: Gabriel Fernandez @ 2015-03-05 9:00 UTC (permalink / raw)
To: Axel Lin, Kishon Vijay Abraham I; +Cc: kernel@vger.kernel.org, Alexandre Torgue
Acked-by: Gabriel Fernandez<gabriel.fernandez@linaro.org>
On 03/05/2015 02:43 AM, Axel Lin wrote:
> Prefer devm_kcalloc over devm_kzalloc with multiply.
> In additional, use sizeof(phy) is incorrect, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> This patch is on top of below patch:
> [PATCH 1/2] phy: miphy28lp: Avoid calling of_get_child_count() multiple times
>
> drivers/phy/phy-miphy28lp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
> index 4fe1755..9334352 100644
> --- a/drivers/phy/phy-miphy28lp.c
> +++ b/drivers/phy/phy-miphy28lp.c
> @@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> miphy_dev->nphys = of_get_child_count(np);
> - miphy_dev->phys = devm_kzalloc(&pdev->dev,
> - sizeof(phy) * miphy_dev->nphys,
> - GFP_KERNEL);
> + miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
> + sizeof(*miphy_dev->phys), GFP_KERNEL);
> if (!miphy_dev->phys)
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 9:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 1:43 [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Axel Lin
2015-03-05 1:44 ` [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO Axel Lin
2015-03-05 9:00 ` Gabriel Fernandez
2015-03-05 9:00 ` [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Gabriel Fernandez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.