* [PATCH] xen/arm: gic: Correctly check if an IRQ is valid in gic_interrupt
@ 2015-03-03 16:36 Julien Grall
2015-03-05 17:28 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-03-03 16:36 UTC (permalink / raw)
To: xen-devel; +Cc: stefano.stabellini, Julien Grall, tim, ian.campbell
The IRQ 1020 is reserved for special purpose, so the check should be
"irq < 1020" rather than "irq < 1021".
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 390c8b0..940fb8e 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -570,7 +570,7 @@ void gic_interrupt(struct cpu_user_regs *regs, int is_fiq)
/* Reading IRQ will ACK it */
irq = gic_hw_ops->read_irq();
- if ( likely(irq >= 16 && irq < 1021) )
+ if ( likely(irq >= 16 && irq < 1020) )
{
local_irq_enable();
do_IRQ(regs, irq, is_fiq);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/arm: gic: Correctly check if an IRQ is valid in gic_interrupt
2015-03-03 16:36 [PATCH] xen/arm: gic: Correctly check if an IRQ is valid in gic_interrupt Julien Grall
@ 2015-03-05 17:28 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-03-05 17:28 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, tim, stefano.stabellini
On Tue, 2015-03-03 at 16:36 +0000, Julien Grall wrote:
> The IRQ 1020 is reserved for special purpose, so the check should be
> "irq < 1020" rather than "irq < 1021".
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked + applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-05 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 16:36 [PATCH] xen/arm: gic: Correctly check if an IRQ is valid in gic_interrupt Julien Grall
2015-03-05 17:28 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.