* [PATCH] ALSA: ac97: ac97_patch: Simplify patch_vt1613_specific()
@ 2015-03-06 16:41 Fabio Estevam
2015-03-06 16:47 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-03-06 16:41 UTC (permalink / raw)
To: tiwai; +Cc: Fabio Estevam, mail, alsa-devel
From: Fabio Estevam <fabio.estevam@freescale.com>
We can simplify the code by returning patch_build_controls() directly.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/pci/ac97/ac97_patch.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
index eca2210..f4234ed 100644
--- a/sound/pci/ac97/ac97_patch.c
+++ b/sound/pci/ac97/ac97_patch.c
@@ -3360,14 +3360,8 @@ AC97_SINGLE("DC Offset removal", 0x5a, 10, 1, 0),
static int patch_vt1613_specific(struct snd_ac97 *ac97)
{
- int err;
-
- err = patch_build_controls(ac97, &snd_ac97_controls_vt1613[0],
- ARRAY_SIZE(snd_ac97_controls_vt1613));
- if (err)
- return err;
-
- return 0;
+ return patch_build_controls(ac97, &snd_ac97_controls_vt1613[0],
+ ARRAY_SIZE(snd_ac97_controls_vt1613));
};
static const struct snd_ac97_build_ops patch_vt1613_ops = {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: ac97: ac97_patch: Simplify patch_vt1613_specific()
2015-03-06 16:41 [PATCH] ALSA: ac97: ac97_patch: Simplify patch_vt1613_specific() Fabio Estevam
@ 2015-03-06 16:47 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2015-03-06 16:47 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, mail, alsa-devel
At Fri, 6 Mar 2015 13:41:42 -0300,
Fabio Estevam wrote:
>
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We can simplify the code by returning patch_build_controls() directly.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Thanks, applied.
Takashi
> ---
> sound/pci/ac97/ac97_patch.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
> index eca2210..f4234ed 100644
> --- a/sound/pci/ac97/ac97_patch.c
> +++ b/sound/pci/ac97/ac97_patch.c
> @@ -3360,14 +3360,8 @@ AC97_SINGLE("DC Offset removal", 0x5a, 10, 1, 0),
>
> static int patch_vt1613_specific(struct snd_ac97 *ac97)
> {
> - int err;
> -
> - err = patch_build_controls(ac97, &snd_ac97_controls_vt1613[0],
> - ARRAY_SIZE(snd_ac97_controls_vt1613));
> - if (err)
> - return err;
> -
> - return 0;
> + return patch_build_controls(ac97, &snd_ac97_controls_vt1613[0],
> + ARRAY_SIZE(snd_ac97_controls_vt1613));
> };
>
> static const struct snd_ac97_build_ops patch_vt1613_ops = {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-06 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-06 16:41 [PATCH] ALSA: ac97: ac97_patch: Simplify patch_vt1613_specific() Fabio Estevam
2015-03-06 16:47 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.