* [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning
@ 2015-03-27 18:44 Andrew Cooper
2015-03-27 18:53 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2015-03-27 18:44 UTC (permalink / raw)
To: Xen-devel
Cc: Wei Liu, Ian Campbell, Andrew Cooper, Ian Jackson,
Xen Coverity Team
Introduced by c/s 1781f00e
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Coverity-IDs: 1291939 (stray semicolon), 1291941 (structually dead code)
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Xen Coverity Team <coverity@xen.org>
---
tools/misc/xen-mfndump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/misc/xen-mfndump.c b/tools/misc/xen-mfndump.c
index 0c018e0..ceeeaa9 100644
--- a/tools/misc/xen-mfndump.c
+++ b/tools/misc/xen-mfndump.c
@@ -41,7 +41,7 @@ int dump_m2p_func(int argc, char *argv[])
}
/* Map M2P and obtain gpfn */
- if ( xc_maximum_ram_page(xch, &max_mfn) < 0 );
+ if ( xc_maximum_ram_page(xch, &max_mfn) < 0 )
{
ERROR("Failed to get the maximum mfn");
return -1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning
2015-03-27 18:44 [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning Andrew Cooper
@ 2015-03-27 18:53 ` Konrad Rzeszutek Wilk
2015-03-30 9:06 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-03-27 18:53 UTC (permalink / raw)
To: Andrew Cooper
Cc: Wei Liu, Ian Jackson, Ian Campbell, Xen Coverity Team, Xen-devel
On Fri, Mar 27, 2015 at 06:44:52PM +0000, Andrew Cooper wrote:
> Introduced by c/s 1781f00e
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Coverity-IDs: 1291939 (stray semicolon), 1291941 (structually dead code)
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Xen Coverity Team <coverity@xen.org>
> ---
> tools/misc/xen-mfndump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/misc/xen-mfndump.c b/tools/misc/xen-mfndump.c
> index 0c018e0..ceeeaa9 100644
> --- a/tools/misc/xen-mfndump.c
> +++ b/tools/misc/xen-mfndump.c
> @@ -41,7 +41,7 @@ int dump_m2p_func(int argc, char *argv[])
> }
>
> /* Map M2P and obtain gpfn */
> - if ( xc_maximum_ram_page(xch, &max_mfn) < 0 );
> + if ( xc_maximum_ram_page(xch, &max_mfn) < 0 )
> {
> ERROR("Failed to get the maximum mfn");
> return -1;
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning
2015-03-27 18:53 ` Konrad Rzeszutek Wilk
@ 2015-03-30 9:06 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-03-30 9:06 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Andrew Cooper, Ian Jackson, Wei Liu, Xen Coverity Team, Xen-devel
On Fri, 2015-03-27 at 14:53 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 27, 2015 at 06:44:52PM +0000, Andrew Cooper wrote:
> > Introduced by c/s 1781f00e
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Coverity-IDs: 1291939 (stray semicolon), 1291941 (structually dead code)
> > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-30 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-27 18:44 [PATCH] tools/xen-mfndump: Remove stray semicolon preventing 'dump-m2p' from functioning Andrew Cooper
2015-03-27 18:53 ` Konrad Rzeszutek Wilk
2015-03-30 9:06 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.