From: Joe Perches <joe@perches.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Ben Widawsky <ben@bwidawsk.net>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Zach Reizner <zachr@google.com>,
kbuild-all@01.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static
Date: Wed, 01 Apr 2015 20:04:55 -0700 [thread overview]
Message-ID: <1427943895.18444.4.camel@perches.com> (raw)
In-Reply-To: <20150402025959.GA15100@snb>
On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
[]
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
[]
> @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
> return 0;
> }
>
> -int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev,
> +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev,
> uint32_t handle, uint64_t *offset)
Hello Fengguang.
When you or your robot does these, can you please
make sure the entire statement is indented properly?
thanks,
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Zach Reizner <zachr@google.com>,
kbuild-all@01.org, Dave Airlie <airlied@redhat.com>,
Adam Jackson <ajax@redhat.com>, Ben Widawsky <ben@bwidawsk.net>,
David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static
Date: Wed, 01 Apr 2015 20:04:55 -0700 [thread overview]
Message-ID: <1427943895.18444.4.camel@perches.com> (raw)
In-Reply-To: <20150402025959.GA15100@snb>
On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
[]
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
[]
> @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
> return 0;
> }
>
> -int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev,
> +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev,
> uint32_t handle, uint64_t *offset)
Hello Fengguang.
When you or your robot does these, can you please
make sure the entire statement is indented properly?
thanks,
next prev parent reply other threads:[~2015-04-02 3:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 2:59 [drm:drm-next 23/23] drivers/gpu/drm/vgem/vgem_drv.c:198:5: sparse: symbol 'vgem_gem_dumb_map' was not declared. Should it be static? kbuild test robot
2015-04-02 2:59 ` kbuild test robot
2015-04-02 2:59 ` [PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static kbuild test robot
2015-04-02 2:59 ` kbuild test robot
2015-04-02 3:04 ` Joe Perches [this message]
2015-04-02 3:04 ` Joe Perches
2015-04-02 9:14 ` Fengguang Wu
2015-04-02 9:14 ` Fengguang Wu
2015-04-02 23:01 ` Zachary Reizner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427943895.18444.4.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@redhat.com \
--cc=ben@bwidawsk.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zachr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.